After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 639623 - Use XRecord mode in syndaemon to preserve a bit power
Use XRecord mode in syndaemon to preserve a bit power
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: mouse
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2011-01-15 22:09 UTC by Pauli
Modified: 2011-02-17 14:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
mouse: Use event driven mode for syndaemon (1.63 KB, patch)
2011-01-15 22:09 UTC, Pauli
committed Details | Review
disable while typing time feature (1.81 KB, patch)
2011-02-11 11:11 UTC, Antonov Nikolay
rejected Details | Review

Description Pauli 2011-01-15 22:09:56 UTC
Created attachment 178408 [details] [review]
mouse: Use event driven mode for syndaemon

Subject: [PATCH] mouse: Use event driven mode for syndaemon

In default polling mode syndaemon wakeups 5 times per second. That
is pretty bad for power consumption with hungry laptop CPUs.

If syndaemon was compiled to include XRecord extension -R parameter
can be used to select even driven mode. Event driven mode wakeups
only when there is KeyPress or KeyRelease event. In that time CPU
is already running so impact for power consumption is lesser.
Comment 1 Antonov Nikolay 2011-02-11 11:08:49 UTC
Pauli, patch works well! Thanks!
Gnome developers, please get it to upstream!
Comment 2 Antonov Nikolay 2011-02-11 11:11:33 UTC
Created attachment 180646 [details] [review]
disable while typing time feature

Patch makes touchpad-idle time configurable by editing gconf key.
(but it is not configurable thought gnome-control-center because I confused by glade & gtk+).

patch for gnome-settings-daemon-2.30.2

Sorry, for my English.
Comment 3 Bastien Nocera 2011-02-11 11:37:47 UTC
Comment on attachment 180646 [details] [review]
disable while typing time feature

First the patch is against 2.30, and we're coding for GNOME 3 now, which doesn't use GConf. That patch is missing schemas changes anyway.

Secondly, it's unrelated to the original bug request.
Comment 4 Bastien Nocera 2011-02-11 11:38:36 UTC
Review of attachment 178408 [details] [review]:

Any reasons why that's not the default mode when syndaemon is compiled with XRecord support?
Comment 5 Pauli 2011-02-11 12:57:29 UTC
(In reply to comment #4)
> Review of attachment 178408 [details] [review]:
> 
> Any reasons why that's not the default mode when syndaemon is compiled with
> XRecord support?

XRecord use to be broken fro a while (xserver 1.5-1.7 if I remember correctly) I guess that could be reason.
Comment 6 Bastien Nocera 2011-02-15 16:09:01 UTC
Peter, any comments on that patch? Looks fine to me, although I don't know how it would work if syndaemon was compiled without XRecord support.
Comment 7 Peter Hutterer 2011-02-16 23:56:00 UTC
syndaemon will automatically fall back to normal mode if record isn't compiled in.

http://cgit.freedesktop.org/xorg/driver/xf86-input-synaptics/tree/tools
/syndaemon.c#n599

though it looks like it'll fail if record was requested and the X server doesn't support it. I'll go fix that up.
Comment 8 Bastien Nocera 2011-02-17 14:04:14 UTC
Attachment 178408 [details] pushed as f7071bf - mouse: Use event driven mode for syndaemon