After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 639213 - gnome-shell.css: specify font size for overview view selector area
gnome-shell.css: specify font size for overview view selector area
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-01-11 14:18 UTC by Dan Winship
Modified: 2011-01-11 17:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gnome-shell.css: specify font size for overview view selector area (838 bytes, patch)
2011-01-11 14:18 UTC, Dan Winship
committed Details | Review

Description Dan Winship 2011-01-11 14:18:28 UTC
I'm not sure that this size is exactly right: at 16px, the descenders of
the "y" and "p" in "Search your computer" get truncated, but at 14px the
text looks too small. (Although maybe that's just because I was used to
it being too big before.)

(Note that without this, the text is large enough that I only see the
top 2/3 of each letter.)
Comment 1 Dan Winship 2011-01-11 14:18:30 UTC
Created attachment 178035 [details] [review]
gnome-shell.css: specify font size for overview view selector area

Previously this was inheriting the default size, which is specified in
pts, and so would make the text larger than its 16px containing box if
you have high DPI.
Comment 2 Owen Taylor 2011-01-11 16:30:40 UTC
Review of attachment 178035 [details] [review]:

Looks fine (though font sizing generally needs attention - we specify various fonts, and not other fonts, and probably all font sizes should be pt based...)
Comment 3 Dan Winship 2011-01-11 17:13:22 UTC
(In reply to comment #2)
> Looks fine (though font sizing generally needs attention - we specify various
> fonts, and not other fonts

adding "font-size: 48px" to #overview's CSS didn't turn up any other problems

> and probably all font sizes should be pt based...)

Yes, they should, but we can't mix pt and px, and if we size the SVGs to pts then they'll get un-pixel-aligned and fuzzy. (Although... "fuzzy" is not really as relevant a concept at higher DPI... Maybe what we want is for "px" to be interpreted as "pt" at high DPI.)
Comment 4 Dan Winship 2011-01-11 17:15:35 UTC
Attachment 178035 [details] pushed as 6bae9ed - gnome-shell.css: specify font size for overview view selector area