After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 639159 - [textoverloay] Add vertical center alignment option
[textoverloay] Add vertical center alignment option
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal enhancement
: 0.10.33
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-01-10 17:30 UTC by Lane Brooks
Modified: 2011-01-24 18:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.30 KB, patch)
2011-01-10 17:30 UTC, Lane Brooks 		committed Details | Review

Description Lane Brooks 2011-01-10 17:30:12 UTC 
Created attachment 177946 [details] [review]
patch

I am not sure why, but the valignment property in textoverlay has top, bottom, baseline, and position, but does not have a center option. The halignment property has a center option. Granted you can dial in a center option using the new position option, but it seems more consistent with the halignment property to also allow a valignment=center option.

The patch is attached. It is only a few lines of code.
Comment 1 Sebastian Dröge (slomo) 2011-01-11 17:19:44 UTC 
Thanks, I'll push this patch after the current gst-plugins-base release. In the future, please attach patches in "git format-patch" format or use "git bz" :)
Comment 2 Sebastian Dröge (slomo) 2011-01-24 18:40:49 UTC 
commit 876bf233fb69903b393c8f5e02b49da4066eb333
Author: Lane Brooks <dirjud@gmail.com>
Date:   Tue Jan 11 18:18:34 2011 +0100

    textoverlay: Add support for vertical center alignment
    
    Fixes bug #639159.