GNOME Bugzilla – Bug 639069
Improve compose-parse.py to ignore comments
Last modified: 2018-02-10 03:20:55 UTC
Please support the ligatures IJ and ij with compose key. Currently AE, ae, OE and oe are supported. Implementing this would increase support for Dutch language.
See also https://help.ubuntu.com/community/GtkComposeTable
Please also add capital SHARP S ẞ which is composed from two capital 'S' and is Unicode U+1E9E. This would increase support for German language.
Created attachment 204076 [details] [review] Support capital ssharp compose sequence and refactoring indentations This patch need to be applied to the following files: compose-parse/compose-parse.py (refactoiring whitespace) compose-parse/gdkkeysyms.h (support capital s sharp ligature) compose-parse/keysyms.txt (support capital s sharp ligature) in order to support captal s sharp ligature compose sequence. To be able to implement the ij and IJ ligature compose sequences, simila changes should be made to the two latter files as is proposed for capital s sharp ligature. Note that part of the patch for compose-parse.py also allows for flawlesly skipping lines with comments whereas that is not nicely handled at the moment.
Please break this into separate patches: one for whitespace changes, one for ss and one for ij, one for comment handling fixes
Created attachment 204089 [details] [review] Adding support for capital Ssharp
Review of attachment 204076 [details] [review]: Replaced by separate patches
Created attachment 204090 [details] [review] Enable filtering of comments
Created attachment 204091 [details] [review] Refactoring of whitespaces
(In reply to comment #4) > Please break this into separate patches: one for whitespace changes, one for ss > and one for ij, one for comment handling fixes Patch has been split and uploaded in three separate patches. However these do not add compose sequence for capital s sharp but offer what is neede to define the compose sequence on. For small and capital ij ligatures, this works and the compose sequence needs to be done. This is relatively trivial work to be done but best done by the person implementing the patch since my knowledge of the exact inner workings is lacking a bit.
Support for the ij digraph may be a nice addition, BUT be careful because - spell checkers / current Dutch dictionaries take do not take IJ into account. So when people use it in texts, words might be wrongfully marked incorrect; - the use of IJ is discouraged in favor of IJ, as explained in http://en.wikipedia.org/wiki/IJ_(digraph)#Encoding . With proper fonts (Deja Vu for example), the letters I and J should already be moved closer to each other when typed in sequence, so there is no pressing need to be able to type the digraph with Compose. My €0,02. ;-)
Noted that ij and IJ ligatures in Dutch should not be used by default. However, they do prove handy when making graphical works. Also for educational purposes, like the previous comment, *not* to use IJ the compose key sequence is handy. To use the ligature in source code to decode 'IJ' to 'I' + 'J' to correct for user input, this compose key sequence is practical too. This will prevent deflation of your two Euro cents. ☺
Review of attachment 204089 [details] [review]: This patch has been moved upstream to https://bugs.freedesktop.org/show_bug.cgi?id=44313
From now on, this bug only relates to patching compose-parse.py for correctly handling comments and to refactor the source file so that whitespaces reposible for the code's hierarchy are TABs and not a mix of TABs and spaces. Therefore, please ignore the comments and patches on ligatures, these have been moved upstream to https://bugs.freedesktop.org/show_bug.cgi?id=44313 These will trickle down when GNOME will update its Compose.pre from upstream x11lib. Only the remaining two patches need to be reviewed, applied, etc. Fixing this will increase the stability and maintainability of compose-parse.py
(In reply to comment #12) > Review of attachment 204089 [details] [review]: > > This patch has been moved upstream to > https://bugs.freedesktop.org/show_bug.cgi?id=44313 That particular subissue about the ligatures (ij, IJ and SS) has been fixed upstream, see http://cgit.freedesktop.org/xorg/lib/libX11/tree/nls/en_US.UTF-8/Compose.pre and update Compose.pre
We're moving to gitlab! As part of this move, we are closing bugs that haven't seen activity in more than 5 years. If this issue is still imporant to you and still relevant with GTK+ 3.22 or master, please consider creating a gitlab issue for it.