GNOME Bugzilla – Bug 638898
XDND: Fix overview triggering for fast movement
Last modified: 2013-03-03 22:35:05 UTC
Quote from https://bugzilla.gnome.org/show_bug.cgi?id=601731#c57 > The removal of the "toggle" behavior of the hot > corner has improved the reliability when triggering the overview a lot - > strangely, only in the case of being "too slow": if I leave the button while > the overview transition is still ongoing, I'm kicked out of the overview. No > obvious idea what's triggering this - would be cool if you manage to track it > down, otherwise I'm OK with handling it in a new bug after landing this. This seems to be caused by leaving the overview while the animation is still ongoing.
Created attachment 177739 [details] [review] XDND: Fix overview triggering for fast movement Don't exit when the over animation is still ongoing.
Review of attachment 177739 [details] [review]: OK seems like this does not handle the case where the user drops while the overview animation is ongoing.
Created attachment 177778 [details] [review] XDND: Fix overview triggering for fast movement Don't exit when the over animation is still ongoing, unless the user really canceled the drag.
Review of attachment 177778 [details] [review]: The approach works, but is not really nice - the expected behavior of drag-begin/drag-end would be that each signal is emitted exactly once per drag-operation. Unfortunately that is not how xdnd works, so we get intermediate events when "crossing" into the overview; still, it would be a lot nicer to detect the "wrong" events in xdnd and not emit the 'drag-begin'/'drag-end' signals in that case. If that approach is too hard, the workaround in this patch is okay-ish though ... ::: js/ui/overview.js @@ +207,3 @@ + this._xdndDeferredLeaveId = 0; + } + else Messed up indentation
This is going to be fixed once Jasper's barrier work lands. *** This bug has been marked as a duplicate of bug 663661 ***