After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 638732 - [regression] libgnomekbd fails with .Xmodmap
[regression] libgnomekbd fails with .Xmodmap
Status: RESOLVED FIXED
Product: libgnomekbd
Classification: Core
Component: Config
2.91.x
Other Linux
: Normal normal
: ---
Assigned To: libgnomekbd maintainers
Sergey V. Udaltsov
Depends on:
Blocks:
 
 
Reported: 2011-01-05 10:23 UTC by Maciej (Matthew) Piechotka
Modified: 2012-09-26 00:01 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Maciej (Matthew) Piechotka 2011-01-05 10:23:46 UTC
It seesm to be trivial but it took some time to find out. g-s-d accepted .Xmodmap files to tweak keyboard. However it is no longer the case with libgnomekbd as it only search for .xmodmap and silently fails if only .Xmodmap is present.

As it is not present in NEWS it cause some confusion - while move of file is trivial fix it would help if both files were checked (as it may cause some confusion in future).
Comment 1 Sergey V. Udaltsov 2011-01-05 22:17:53 UTC
Ok, committed. Easy one. Please check from git.
Comment 2 Maciej (Matthew) Piechotka 2011-03-13 14:57:04 UTC
Reopened for regression in 2.91.91 (this time for .xmodmap)
Comment 3 Sergey V. Udaltsov 2011-03-13 15:07:22 UTC
both files are analyzed. Does it work ok for .Xmodmap?
Comment 4 Maciej (Matthew) Piechotka 2011-03-19 14:05:10 UTC
(In reply to comment #3)
> both files are analyzed. Does it work ok for .Xmodmap?

Yes. It does.
Comment 5 Sergey V. Udaltsov 2011-03-20 01:54:01 UTC
Could you please run gnome-settings-daemon with envvar XKL_DEBUG=150

It should show (at some point) "Loading custom xmodmap file ...."

Will it see that? What would be the difference for .Xmodmap and .xmodmap?
Comment 6 Maciej (Matthew) Piechotka 2011-03-21 19:34:14 UTC
In case of .Xmodmap:

[1300734979,150,gkbd-keyboard-config.c:gkbd_keyboard_config_activate/]  Loading custom xmodmap file /home/mpiechotka/.Xmodmap
Comment 7 Sergey V. Udaltsov 2011-03-21 21:11:33 UTC
Could you please add the following line to libgnomekbd/gkbd-keyboard-config.c after line 591 (before g_file_test call):

    xkl_debug (150, "Checking custom xmodmap file[%d] %s\n", i, xmodmap_file);

then rebuild and reinstall libgnomekbd.

What do you see on output of g-s-d (again, with XKL_DEBUG=150) - for .xmodmap and for .Xmodmap?
Comment 8 Maciej (Matthew) Piechotka 2012-09-26 00:01:09 UTC
Closing - I no longer use xmodmap but it worked 3.4-ish version.