After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 638728 - gnome-shell.in: Really never add empty elements to LD_LIBRARY_PATH
gnome-shell.in: Really never add empty elements to LD_LIBRARY_PATH
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-01-05 09:53 UTC by Vincent Untz
Modified: 2011-01-05 11:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gnome-shell.in: Really never add empty elements to LD_LIBRARY_PATH (1.53 KB, patch)
2011-01-05 09:53 UTC, Vincent Untz 		committed Details | Review

Description Vincent Untz 2011-01-05 09:53:27 UTC 
This complements the fix from c6eb2761, to make sure that we don't use the pre-existing $LD_LIBRARY_PATH if it's set but empty.  

Both commits fix CVE-2010-4000.
Comment 1 Vincent Untz 2011-01-05 09:53:30 UTC 
Created attachment 177555 [details] [review]
gnome-shell.in: Really never add empty elements to LD_LIBRARY_PATH

This complements the fix from c6eb2761, to make sure that we don't use
the pre-existing $LD_LIBRARY_PATH if it's set but empty.

Both commits fix CVE-2010-4000.
Comment 2 Vincent Untz 2011-01-05 09:57:27 UTC 
Downstream reference: https://bugzilla.novell.com/show_bug.cgi?id=642827
Comment 3 Florian Müllner 2011-01-05 11:29:20 UTC 
Review of attachment 177555 [details] [review]:

Makes sense to me.