After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 638588 - [Patch] Exposing the selected notebook in "Search All Notes" to add-ins
[Patch] Exposing the selected notebook in "Search All Notes" to add-ins
Status: RESOLVED FIXED
Product: tomboy
Classification: Applications
Component: General
1.5.x
Other All
: Normal enhancement
: 1.6.0
Assigned To: Tomboy Maintainers
Tomboy Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-01-03 17:21 UTC by Robert Nordan
Modified: 2011-01-09 15:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
A patch changing the needed method from private to public. (995 bytes, patch)
2011-01-03 17:21 UTC, Robert Nordan
committed Details | Review

Description Robert Nordan 2011-01-03 17:21:33 UTC
Created attachment 177418 [details] [review]
A patch changing the needed method from private to public.

For add-ins to be able to perform operations such as "Export notebook to html" in the "Search All Notes" window (something I'm working on right now), they need to be able to find out which notebook is currently selected. This patch simply changes GetSelectedNotebook() in the class NoteRecentChanges from private to public in order to expose the functionality.
Comment 1 Sandy Armstrong 2011-01-03 22:35:59 UTC
Review of attachment 177418 [details] [review]:

Looks good to me. Do you have GNOME git access, or should I push for you?
Comment 2 Robert Nordan 2011-01-03 22:44:48 UTC
I don't have access, so it would be nice if you could do it. :-)
Comment 3 Stefan Schweizer 2011-01-09 15:56:24 UTC
Review of attachment 177418 [details] [review]:

I just pushed the patch.