After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 638381 - {input,output}-selector: double-check API before release
{input,output}-selector: double-check API before release
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal blocker
: 0.10.32
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-12-31 02:16 UTC by Tim-Philipp Müller
Modified: 2011-01-06 19:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
output-selector: Add pad-negotiation-mode property (13.30 KB, patch)
2011-01-04 21:36 UTC, Thiago Sousa Santos
none Details | Review

Description Tim-Philipp Müller 2010-12-31 02:16:13 UTC
Esp. the signals / actions, return values etc.
Comment 1 Sebastian Dröge (slomo) 2010-12-31 11:58:36 UTC
input-selector: API looks good to me except for the select-all property. IMHO it should go away, it's only for a very specific use case and the farsight funnel element does exactly this.
We should add the GstSelectorPad to the docs somehow, the pad subclass has some useful properties.

output-selector: Looks good too but it might be a good idea to add correct setcaps/getcaps functions to the pads
Comment 2 Thiago Sousa Santos 2011-01-04 21:36:52 UTC
Created attachment 177523 [details] [review]
output-selector: Add pad-negotiation-mode property

Adds getcaps/setcaps to output-selector and adds a property
to select which type of negotiation should be done.

The available modes are:
 * none:   no negotiation (current behavior), getcaps return ANY and
           setcaps aren't set on any of the peers
 * all:    use all pads (default), getcaps returns the intersection of
           peer pads and setcaps is set on all peers
 * active: getcaps and setcaps are proxied to the active pad
Comment 3 Tim-Philipp Müller 2011-01-06 19:28:17 UTC
Renamed the actual enums in the code a bit (not sure it matters here though):

commit 757dc90faa163a235e1d16791a0a0f8c74715768
Author: Thiago Santos <thiago.sousa.santos@collabora.co.uk>
Date:   Tue Jan 4 12:42:50 2011 -0300

    output-selector: Add pad-negotiation-mode property
    
    Adds getcaps/setcaps to output-selector and adds a property
    to select which type of negotiation should be done.
    
    The available modes are:
     * none:   no negotiation (current behavior), getcaps return ANY and
               setcaps aren't set on any of the peers
     * all:    use all pads (default), getcaps returns the intersection of
               peer pads and setcaps is set on all peers
     * active: getcaps and setcaps are proxied to the active pad
    
    https://bugzilla.gnome.org/show_bug.cgi?id=638381

commit c8ffd4e395261cdf6a88ac3ff13539fcc3add5cc
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Thu Jan 6 18:18:29 2011 +0000

    docs: mention extra input-selector pad properties
    
    https://bugzilla.gnome.org/show_bug.cgi?id=638381