After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 638191 - docs: rename deletes files
docs: rename deletes files
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: afc backend and volume monitor
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2010-12-28 15:46 UTC by Bastien Nocera
Modified: 2011-03-27 00:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
afc: Fix renaming files moving them to the root dir (2.80 KB, patch)
2011-03-26 12:20 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2010-12-28 15:46:11 UTC 
Try renaming files inside a Documents/ directory and they'll disappear. Need to test g_vfs_backend_afc_set_display_name().
Comment 1 Martin Szulecki 2011-03-26 10:41:57 UTC 
We lost the conversation and your patch due to the database issue on bgo thus I'll try to write up what I still remember.

Downstream Bug:
http://libiphone.lighthouseapp.com/projects/27916/tickets/196-bug-when-renaming-a-file-on-iphone

I had tested your patch and it fixed the issue so it should be fine to commit.

It could make sense to backport it to the 1.6.x series which seems trivial.
Comment 2 Bastien Nocera 2011-03-26 12:20:18 UTC 
Created attachment 184282 [details] [review]
afc: Fix renaming files moving them to the root dir

We were moving and renaming files, instead of just renaming them,
as the display_name wasn't properly rooted to the existing directory.
Comment 3 Bastien Nocera 2011-03-26 12:40:03 UTC 
Asked for freeze break for those. Should get committed to the stable branches as well.
Comment 4 Bastien Nocera 2011-03-27 00:39:01 UTC 
Pushed to master, gnome-3-0 and gnome-2-32

Attachment 184282 [details] pushed as db7558c - afc: Fix renaming files moving them to the root dir