After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 637847 - Adjust for Folks avatar and presence interface renames
Adjust for Folks avatar and presence interface renames
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
2.91.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on: 627397
Blocks:
 
 
Reported: 2010-12-23 01:26 UTC by Travis Reitter
Modified: 2011-02-01 01:02 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Adjust for Folks interface renames: HasAvatar -> AvatarOwner, HasPresence -> PresenceOwner (11.13 KB, patch)
2010-12-23 03:00 UTC, Travis Reitter
reviewed Details | Review

Description Travis Reitter 2010-12-23 01:26:25 UTC
Folks will break the following API (again):

  * FolksHasAvatar -> FolksAvatarOwner
  * FolksHasPresence -> FolksPresenceOwner

for bug #627397, which will break Empathy's build. See the comments for rationale.

Sorry about the noise. This should be our final change for these interface names.
Comment 1 Travis Reitter 2010-12-23 03:00:26 UTC
Created attachment 176915 [details] [review]
Adjust for Folks interface renames: HasAvatar -> AvatarOwner, HasPresence -> PresenceOwner

Squashed diff of branch:

http://git.collabora.co.uk/?p=user/treitter/empathy.git;a=shortlog;h=refs/heads/bgo637847-folks-interface-changes
Comment 2 Guillaume Desmottes 2010-12-23 13:38:52 UTC
Review of attachment 176915 [details] [review]:

Yep, please merge once folks has been released and the wiki and jhbuild have been updated.
Comment 3 Travis Reitter 2011-02-01 01:02:45 UTC
(In reply to comment #2)
> Review of attachment 176915 [details] [review]:
> 
> Yep, please merge once folks has been released and the wiki and jhbuild have
> been updated.

I've pushed the (rebased) changes to master, though not to any other branches (so please do so if necessary).

jhbuild is using Folks from git, so nothing to update there.

I've updated http://live.gnome.org/TwoPointNinetyone/ExternalDependencies

====================================

commit 41f5717611c6bb3236ae78a187fd5753bbd9ccf3
Author: Travis Reitter <travis.reitter@collabora.co.uk>
Date:   Wed Dec 22 17:22:59 2010 -0800

    Adjust for FolksHasPresence -> FolksPresenceOwner
    
    Fixes bgo#637847.

 libempathy-gtk/empathy-individual-store.c  |   31 +++++++++++++++------------
 libempathy-gtk/empathy-individual-view.c   |    2 +-
 libempathy-gtk/empathy-individual-widget.c |   24 ++++++++++----------
 libempathy-gtk/empathy-persona-store.c     |   16 ++++++++------
 libempathy-gtk/empathy-ui-utils.c          |    4 +-
 libempathy/empathy-contact.c               |   20 +++++++++---------
 6 files changed, 51 insertions(+), 46 deletions(-)

commit dfffa71d1d33714b331faaac367110716d56c72c
Author: Travis Reitter <travis.reitter@collabora.co.uk>
Date:   Wed Dec 22 17:46:06 2010 -0800

    Adjust for FolksHasAvatar -> FolksAvatarOwner
    
    Helps bgo#637847.

 libempathy-gtk/empathy-ui-utils.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)