After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 637768 - incomplete keyboard navigation, enter/space keypresses are ignored
incomplete keyboard navigation, enter/space keypresses are ignored
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Sidebar
2.91.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 631624 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-12-21 17:52 UTC by Stefano Teso
Modified: 2011-01-27 03:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (1.22 KB, patch)
2011-01-19 13:45 UTC, Stefano Teso 		committed Details | Review

Description Stefano Teso 2010-12-21 17:52:07 UTC 
As of nautilus 2.91.4 [debian package from experimental, nautilus_2.91.4-1_amd64.deb], the places sidebar doesn't react to Enter keypresses. In other words, it is possible to navigate the sidebar entries easily, but it is impossible to open them in the main window with either enter or space. I guess this is not intentional.

I can't test whether this bug is fixed in 2.91.5 or git master, unfortunately; in case, sorry for the noise.

Thanks
Comment 1 Stefano Teso 2011-01-19 13:45:46 UTC 
Created attachment 178720 [details] [review]
proposed patch

proposed patch to implement the requested behavior. please review. IMHO it should be seriously considered for 3.0.

thanks,
Comment 2 Cosimo Cecchi 2011-01-23 01:44:52 UTC 
Review of attachment 178720 [details] [review]:

Thanks for the patch, looks good. Do you have commit access? If so, feel free to push to master.
Comment 3 Stefano Teso 2011-01-23 09:58:16 UTC 
No, I don't have commit access, and given my experience developing GTK apps, frankly I don't deserve it ;-) Thanks Cosimo!
Comment 4 Stefano Teso 2011-01-26 15:50:52 UTC 
BTW, https://bugzilla.gnome.org/show_bug.cgi?id=631624 is a duplicate of this bug, however I don't have the permissions to mark it so.
Comment 5 André Klapper 2011-01-26 16:48:02 UTC 
*** Bug 631624 has been marked as a duplicate of this bug. ***
Comment 6 Cosimo Cecchi 2011-01-27 03:45:37 UTC 
Pushed to master now, closing.