After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 637532 - applemedia: redundant declaration of 'parent_class'
applemedia: redundant declaration of 'parent_class'
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Mac OS
: Normal normal
: 0.10.21
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-12-18 20:51 UTC by Leo Singer
Modified: 2010-12-18 21:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (1.68 KB, patch)
2010-12-18 20:51 UTC, Leo Singer 		committed Details | Review

Description Leo Singer 2010-12-18 20:51:22 UTC 
Created attachment 176680 [details] [review]
Proposed patch

There are two source files in the applemedia plugin that have redundant declaration warnings because 'parent_class' is declared both explicitly in the source code and also by the call to GST_BOILERPLATE_FULL.

cc1: warnings being treated as errors
miovideosrc.c:88: warning: redundant redeclaration of 'parent_class'
miovideosrc.c:86: warning: previous declaration of 'parent_class' was here

and

cc1obj: warnings being treated as errors
qtkitvideosrc.m:469: warning: redundant redeclaration of 'parent_class'
qtkitvideosrc.m:89: warning: previous declaration of 'parent_class' was here


The attached patch removes the redundant declaration from both source files, but in qtkitvideosrc.c I also moved the call to GST_BOILERPLATE_FULL above all of the functions that make use of parent_class.
Comment 1 Tim-Philipp Müller 2010-12-18 21:33:02 UTC 
Thanks, pushed (added bug number and modified message a bit)

 commit 369f41913cce96658d7a0f26e02f58200ef40af3
 Author: Leo Singer <leo.singer@ligo.org>
 Date:   Sat Dec 18 12:48:42 2010 -0800

    applemedia: fix compiler warning: redundant declaration of 'parent_class'
    
    GST_BOILERPLATE_FULL declares parent_class as well.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=637532