GNOME Bugzilla – Bug 636969
gtk: Use symbolic icons in GtkVolumeButton
Last modified: 2010-12-17 13:24:19 UTC
So that movie players can use GtkVolumeButton and still get the appropriate icons.
Created attachment 176182 [details] [review] gtk: Use symbolic icons in GtkVolumeButton When the application prefers dark themes.
There are dark symbolic icons, too. So I suggest, this should be documented, otherwise it could be surprising.
(In reply to comment #2) > There are dark symbolic icons, too. So I suggest, this should be documented, > otherwise it could be surprising. No there aren't. The symbolic icons recolour.
They exist, I have seen them and tried them :-) Maybe that is a problem elsewhere, and they are not being used correctly in some places, or the icon themes in question are wrong. Any pointers would be helpful, if this is indeed wrong.
(In reply to comment #4) > They exist, I have seen them and tried them :-) Then they're broken. > Maybe that is a problem elsewhere, and they are not being used correctly in > some places, or the icon themes in question are wrong. Any pointers would be > helpful, if this is indeed wrong. If you're talking about the ones in gnome-shell, then there's bugs already filed. Otherwise it's hard to know without more specifics (which aren't related to this bug anyway).
Hmm, I'm not convinced that switching to symbolic icons only when using a dark theme is the best approach. Wouldn't it be more natural to always use the symbolic icons, dark or not ?
(In reply to comment #6) > Hmm, I'm not convinced that switching to symbolic icons only when using a dark > theme is the best approach. Wouldn't it be more natural to always use the > symbolic icons, dark or not ? That would mean that applications like Rhythmbox, sound-juicer, Banshee, etc. would need to fully switch to using symbolic icons in their toolbars. I could easily switch this code to using a property instead, so that applications that choose to use symbolic icons for the volume drop-down don't need to reimplement the full widget.
After discussing it with Jakub, we think that we shouldn't link the dark theme to the use of symbolic icons, even if it's possible that both would usually be used together. I'll cook up a new patch that uses a property then.
Yea it's a tough call. There are only a few cases when it's desirable to use symbolic icons, it's not a fashionable new style we want to apply everywhere. Every time you are dealing with possible visual "pollution" where a set of icons could be grabbing too much attention away from the content (fullscreen video playback, status icons on a dash/panel). I've outlined some of the basic situations where to use symbolic icons here -- http://live.gnome.org/GnomeShell/Design/Whiteboards/SymbolicIcons/UseGuidelines Dark themes are preferred for similar reasons as they make chrome less visually polluting, making the content clearly visible. Yet I am torn to link the two together and propose to always use symbolic icons when dark themes are used.
Created attachment 176469 [details] [review] gtk: Add symbolic property for GtkVolumeButton When the application prefers symbolic icons, avoids having to reimplement the button in the software itself.
Tested in Totem with a bunch of .ui one-liners, and it works nicely.
As discussed on IRC with mclasen. commit 23c1d1cbc99f927a78fb03665c7fd74ef7801611 Author: Bastien Nocera <hadess@hadess.net> Date: Fri Dec 10 15:05:50 2010 +0000 gtk: Add symbolic property for GtkVolumeButton When the application prefers symbolic icons, avoids having to reimplement the button in the software itself. https://bugzilla.gnome.org/show_bug.cgi?id=636969