GNOME Bugzilla – Bug 636371
alt-f1 opens but does not close the overview
Last modified: 2011-01-10 20:28:09 UTC
alt-f1 works to open the overview, but not to close it. Alessandro Crismani notes that Super key works both to open and close it, so I'm pretty sure this is a bug. (Obviously, the use case for this is a keyboard with no Super key, like my 1991 model :>)
Created attachment 177699 [details] [review] main: allow Alt-F1 to exit the overview Also, change _globalKeyPressHandler to handle KEY_PRESS, not KEY_RELEASE, for consistency with other code (and so that the combination of an Alt-F1 press and release doesn't first enter the overview and then immediately exit it).
Review of attachment 177699 [details] [review]: Hmm, this makes Super inconsistent for going into the overview and leaving the overview - it's done on release when going into the overview to allow for future handling of Super+<key> bindings. Guess that's OK, can revisit if we want Super+<key> bindings to be active in the overview.
Review of attachment 177699 [details] [review]: Looks good to me; minor nit: would have been nice to explicitly mention you'd looked at the other key press handlers and checked they wouldn't break with the keydown->keyup change (I assume you did, and I just looked too).
Attachment 177699 [details] pushed as ed83b54 - main: allow Alt-F1 to exit the overview