GNOME Bugzilla – Bug 636272
[PATCH] Doesn't compile against the latest GTK3
Last modified: 2011-01-11 07:35:17 UTC
Created attachment 175695 [details] [review] Updates to the latest GTK3 Doesn't compile against the latest GTK3, the attached patch fixes this. Note the patch doesn't support GTK2 anymore, my recommendation is to only support GTK2 in the 2.32 series.
Review of attachment 175695 [details] [review]: As far as I see, there are two issues: 1. Use of GtkComboBox instead of GtkComboBoxEntry. 2. Use of a Cairo context instead of GdkWindow. Both of them should compile against gtk2, or I missing something?
3. Replacement of expose-event with draw (that's the annoying one).
Germán, GtkComboBox has new API that is not available in 2.x, so it won't compile on both. So either we #ifdef that part of the code, or we do as Robert suggests, which is to force use of GTK3. I'm ok with doing that for the 3.x version, so unless Germán has something against it, please push your patch
(In reply to comment #3) > Germán, GtkComboBox has new API that is not available in 2.x, so it won't > compile on both. So either we #ifdef that part of the code, or we do as Robert > suggests, which is to force use of GTK3. I'm ok with doing that for the 3.x > version, so unless Germán has something against it, please push your patch Rodrigo, According to the documentation, it is available since 2.24: http://library.gnome.org/devel/gtk/unstable/GtkComboBox.html#gtk-combo-box-set-entry-text-column
Review of attachment 175695 [details] [review]: Ok, I just committed.
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.