GNOME Bugzilla – Bug 635393
Volume control regressions
Last modified: 2010-11-30 12:20:28 UTC
Created attachment 174932 [details] Screenshot The look of the volume control regressed during the last few days compared to older revisions: - the "bubble" is smaller, making the slider smaller as well - the top left corner of the bubble is broken - no longer shows percentage - no longer fills active range (0%-actual percentage) with other color
> - the "bubble" is smaller, making the slider smaller as well that could be fixed > - the top left corner of the bubble is broken that's fixed by part of the patch in bug 618312 comment 17 > - no longer shows percentage That's intentional and considered an improvement > - no longer fills active range (0%-actual percentage) with other color I'm pretty sure it didn't do that before
>> hat's intentional and considered an improvement How could this be an improvement? An important information is no longer visible >> I'm pretty sure it didn't do that before Hmm... maybe I use totem too much these days and its just what the gtk theme does... but without this, the control looks kind of dead.
FWIW the lack of "mute" is kind of annoying. You can't say "shut up for a while" and go to the previous volume level afterwards. You'd have to set it to 0 or back to where it was.
(In reply to comment #2) > >> hat's intentional and considered an improvement > How could this be an improvement? An important information is no longer visible The percentage was superfluous information: the slider already communicates the current level in relation to the possible volume range. Removing the percentage makes the menu more efficient by reducing visual noise. I agree about the menu width - that needs correcting.
Created attachment 175061 [details] [review] boxpointer: don't draw the arrow overlapping the corners In some circumstances, a boxpointer would draw itself with the arrow partially overlapping the rounded corner, causing things to not line up correctly. Don't do that. And while we're at it, don't draw the pointer very very close to the corner either, since it looks odd if the corner flows directly into the arrow.
Created attachment 175062 [details] [review] volume: give the slider a minimum width The simpler volume menu resulted in a slider that was too short. Fix that.
Review of attachment 175062 [details] [review]: Looks good as-is, but actually any popup menu slider less than 15em will have the same problem. Maybe it is better to add the min-width declaration to .popup-slider-menu-item
Review of attachment 175061 [details] [review]: Finally had the occasion to test it, and definitely looks good.
pushed with the change to add min-width to all sliders, not just volume Attachment 175061 [details] pushed as 6adc123 - boxpointer: don't draw the arrow overlapping the corners