After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 635169 - Please support gobject-introspection
Please support gobject-introspection
Status: RESOLVED FIXED
Product: libnotify
Classification: Platform
Component: general
git master
Other Linux
: Normal enhancement
: ---
Assigned To: Martin Pitt
Depends on:
Blocks: 585444
 
 
Reported: 2010-11-18 11:24 UTC by Martin Pitt
Modified: 2010-11-18 13:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
add some more GIR annotations (2.15 KB, patch)
2010-11-18 13:08 UTC, Martin Pitt
committed Details | Review
current GIR test script (1.65 KB, text/x-python)
2010-11-18 13:09 UTC, Martin Pitt
  Details

Description Martin Pitt 2010-11-18 11:24:37 UTC
libnotify does not yet build a GIR. Since I need it for a project of mine, I'm currently looking into adding it.

See http://live.gnome.org/GnomeGoals/AddGObjectIntrospectionSupport
Comment 1 Martin Pitt 2010-11-18 13:08:35 UTC
Created attachment 174769 [details] [review]
add some more GIR annotations

Ah, seems that Jonathan Matthew and I collided mid-air, he committed a similar patch to mine.

This patch adds some missing GIR annotations, can I push this?

I'm also currently writing a test Python script which exercises the locally built typelib. It currently bails out on calling add_action() on an assert violation in pygi, but the main functionality is already working fine. Do you want me to commit the test script (tests/test-gir.py) to trunk as well?
Comment 2 Martin Pitt 2010-11-18 13:09:24 UTC
Created attachment 174770 [details]
current GIR test script

Current version of my GIR test script
Comment 3 William Jon McCann 2010-11-18 13:14:14 UTC
Looks good.  Please add the test as well.  Thanks.
Comment 4 Martin Pitt 2010-11-18 13:16:34 UTC
Also, it should be considered to change the namespace version to 0.4 to match the ABI, not the project version number. I think that's more in line with the already existing GIR versions?
Comment 5 Martin Pitt 2010-11-18 13:17:29 UTC
Comment on attachment 174769 [details] [review]
add some more GIR annotations

Thanks, committed the annotations.
Comment 6 Martin Pitt 2010-11-18 13:22:09 UTC
Python test script committed as b2020b7f2acf380c5e40fa701a98424ade5be6c0

Thanks for the super-fast review!
Comment 7 William Jon McCann 2010-11-18 13:23:28 UTC
(In reply to comment #4)
> Also, it should be considered to change the namespace version to 0.4 to match
> the ABI, not the project version number. I think that's more in line with the
> already existing GIR versions?

Doesn't match the API though right?