After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 635069 - wrong documentation for atk_text_get_text_after_offset
wrong documentation for atk_text_get_text_after_offset
Status: RESOLVED FIXED
Product: atk
Classification: Platform
Component: docs
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Li Yuan
Li Yuan
Depends on:
Blocks:
 
 
Reported: 2010-11-17 13:23 UTC by Fernando Herrera
Modified: 2010-11-30 02:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch fixing docs (906 bytes, patch)
2010-11-17 13:28 UTC, Fernando Herrera
committed Details | Review

Description Fernando Herrera 2010-11-17 13:23:30 UTC
Docs for atk_text_get_text_after_offset for ATK_TEXT_BOUNDARY_LINE_END say:

If the boundary_type is ATK_TEXT_BOUNDARY_LINE_END the returned string is from the line end at or after the offset to the next line start.

and should say:

If the boundary_type is ATK_TEXT_BOUNDARY_LINE_END the returned string is from the line end at or after the offset to the next line end.

that is what the implemntation does and to match start -> start, end -> end pattern in all the other functions (before_offset and at_offset).
Comment 1 Fernando Herrera 2010-11-17 13:28:37 UTC
Created attachment 174678 [details] [review]
Patch fixing docs
Comment 2 Li Yuan 2010-11-18 09:01:31 UTC
Review of attachment 174678 [details] [review]:

The patch is OK with me.
Comment 3 Javier Jardón (IRC: jjardon) 2010-11-30 02:59:12 UTC
Comment on attachment 174678 [details] [review]
Patch fixing docs

commit 00f61837ebb516435894dc4002bb7d8515d97a69
Comment 4 Javier Jardón (IRC: jjardon) 2010-11-30 02:59:21 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.