After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 634882 - Usage of deprecated GLib API (g_source_get_current_time)
Usage of deprecated GLib API (g_source_get_current_time)
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
2.23.x
Other Windows
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
: 634277 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-11-15 05:39 UTC by Fan, Chun-wei
Modified: 2010-11-15 15:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix the gtk_tool_item_group_get_animation_timestamp in gtk/gtktoolitemgroup.c (547 bytes, patch)
2010-11-15 05:39 UTC, Fan, Chun-wei 		committed Details | Review

Description Fan, Chun-wei 2010-11-15 05:39:52 UTC 
Created attachment 174490 [details] [review]
Fix the gtk_tool_item_group_get_animation_timestamp in gtk/gtktoolitemgroup.c

Hi, in gtk/gtktoolitemgroup.c, g_source_get_current_time (deprecated in GLib 2.27.3) is being used in gtk_tool_item_group_get_animation_timestamp, so one can fix this either by not defining G_DISABLE_DEPRECATED during compilation or fix the function.

The following is my proposed patch, for GLib 2.27.3 and later.  Please let me know of any comments.  Thanks
Comment 1 Fan, Chun-wei 2010-11-15 06:14:03 UTC 
*** Bug 634277 has been marked as a duplicate of this bug. ***
Comment 2 Javier Jardón (IRC: jjardon) 2010-11-15 15:23:54 UTC 
Comment on attachment 174490 [details] [review]
Fix the gtk_tool_item_group_get_animation_timestamp in gtk/gtktoolitemgroup.c

Thanks for the patch; committed with some modifications in commit d0fb9f601441b5646f936966ecb9f3d74c842628

Please, use git format-patch next time to generate the patch. Take a look here: http://live.gnome.org/Git/CommitMessages