After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 634435 - crasher .ppt
crasher .ppt
Status: RESOLVED FIXED
Product: libgsf
Classification: Core
Component: MS OLE2 & Properties
1.14.x
Other Linux
: Normal normal
: ---
Assigned To: Stepan Kasal
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2010-11-09 16:39 UTC by Caolan McNamara
Modified: 2010-11-10 17:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
direct fix (722 bytes, application/octet-stream)
2010-11-09 16:39 UTC, Caolan McNamara 		  Details
sigh, fix typo (669 bytes, patch)
2010-11-09 16:59 UTC, Caolan McNamara 		none Details | Review

Description Caolan McNamara 2010-11-09 16:39:04 UTC 
Created attachment 174141 [details]
direct fix

I have a .ppt here from https://bugzilla.redhat.com/show_bug.cgi?id=650874 which I don't have permission (yet) to share. In gsf_blob_new it triggers the g_return_val_if_fail size > 0 so early returns without setting a error, so case VT_CF in gsf/gsf-msole-utils.c crashes trying to print the error->message.

Attached is quick fix to not crash
Comment 1 Caolan McNamara 2010-11-09 16:59:34 UTC 
Created attachment 174144 [details] [review]
sigh, fix typo
Comment 2 Morten Welinder 2010-11-10 17:47:16 UTC 
Thanks.  Committed.

Reopen if file becomes available unless the file is known to be corrupt
(in which we what we do is right).