GNOME Bugzilla – Bug 634197
[Patch] Make CA cert paths configurable
Last modified: 2011-08-29 10:12:37 UTC
Currently Empathy hard codes the CA cert path to look in /etc/ssl/certs/ca-certificates.crt, which causes distros that don't use this path (Fedora, Suse, etc) to not have there certs imported. I'll add a patch to make this configurable.
Created attachment 173971 [details] [review] Configurable CA certs patch This patch make the CA certs path configurable, so that distros that don't use /etc/ssl/certs/ca-certificates.crt can have their certs imported. This will prevent a lot of bug reports about google talk ssl errors for non-debian based distros. Btw, this patch was made against the 2-32 branch.
Review of attachment 173971 [details] [review]: Thanks for the patch but I'd prefer to keep it the same as the similar configure flag in gabble. I could be convinced that Gabble and Empathy should use the same flag as gio but then Gabble should be changed first. Could you check your distro is building Gabble with the right flag btw?
It looks like tp-gabble configure flag works, but the gio configure code is a *lot* nicer for distros (RHL, Fedora, Centos, etc) that don't use /etc/ssl.
Sure; could you please open a gabble bug on bugs.freedesktop.org for that ?
(In reply to comment #4) > Sure; could you please open a gabble bug on bugs.freedesktop.org for that ? Done. https://bugs.freedesktop.org/show_bug.cgi?id=31474
Review of attachment 173971 [details] [review]: Ok I'm convince this is the right option to use. Something seems work with your patch though. ::: configure.ac @@ +239,3 @@ + AC_MSG_RESULT($with_ca_file) + if ! test -f "$with_ca_file"; then + AC_MSG_ERROR([No such file '$with_ca_file'. Use --with-ca-file=path to set, or --without-ca-file to disable]) --without-ca-file doesn't seem to be used any where.
--without-FOO is exactly equivalent to --with-FOO=no, and follows the same code paths, so I think the patch is fine.
Ah cool, I merged the patch to master. Thanks guys! This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Any chance this can also be merge to the 2.32.x branch if you do another release? I'm having to patch the Fedora version, so our ca-cert is picked up.
I already released 2.32.1 and there is no other 2.32 release planned, so I don't think it's worth it. Just patch the Fedora package.
Actually I'm goint to make a 2.32.1 so I backported the patch :)