After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 634091 - Adapt to gnome-desktop API changes
Adapt to gnome-desktop API changes
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Display
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Soren Sandmann Pedersen
Control-Center Maintainers
Depends on:
Blocks: 630913
 
 
Reported: 2010-11-05 15:32 UTC by Giovanni Campagna
Modified: 2011-01-06 20:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Adapt to gnome-desktop API changes (38.83 KB, patch)
2010-11-05 15:33 UTC, Giovanni Campagna 		accepted-commit_now Details | Review
Adapt to gnome-desktop API changes (42.35 KB, patch)
2010-11-10 14:56 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2010-11-05 15:32:57 UTC 
Per bug 630913, GnomeRR is about to change API for better bindability.
We need to adapt the display panel (former xrandr applet) to that.
Comment 1 Giovanni Campagna 2010-11-05 15:33:29 UTC 
Created attachment 173885 [details] [review]
Adapt to gnome-desktop API changes

GnomeRRScreen, GnomeRRConfig and GnomeRROutputInfo (formerly
GnomeOutputInfo) have turned into opaque GObjects. Use accessors
for modifying them, and allocate/free them as GObjects.
Comment 2 Rodrigo Moya 2010-11-05 15:53:37 UTC 
Review of attachment 173885 [details] [review]:

Looks good
Comment 3 Rodrigo Moya 2010-11-08 12:44:52 UTC 
Giovanni, is this patch blocked on something? Shall I push it master?
Comment 4 Giovanni Campagna 2010-11-08 13:23:41 UTC 
Well, gnome-control-center will fail to build if the relevant patch is not pushed to gnome-desktop (bug 630913). Similarly we need to patch gnome-settings-daemon at the same time (bug 634095).
Comment 5 Giovanni Campagna 2010-11-10 14:56:58 UTC 
Created attachment 174201 [details] [review]
Adapt to gnome-desktop API changes

1. All header files have been moved to libgnome-desktop/
2. GnomeRRScreen, GnomeRRConfig and GnomeRROutputInfo (formerly
GnomeOutputInfo) have turned into opaque GObjects. Use accessors
for modifying them, and allocate/free them as GObjects.
Comment 6 Rodrigo Moya 2010-11-10 15:21:04 UTC 
Review of attachment 174201 [details] [review]:

Looks good
Comment 7 Rodrigo Moya 2010-11-10 15:26:54 UTC 
hmm, well, this doesn't compile with gnome-desktop master, seems you reverted some stuff?
Comment 8 Giovanni Campagna 2010-11-10 17:31:09 UTC 
only part of the patch on gnome-desktop was reviewed, and thus only part was commited

(actually, I did push everything, but only by accident, so I had to revert it)
Comment 9 Giovanni Campagna 2010-11-28 14:45:12 UTC 
Following Federico's suggestion on bug 630913, pushed to "gobject-gnomerr" branch for review.
Comment 10 Giovanni Campagna 2011-01-06 20:09:42 UTC 
The branch has been merged to master. Closing...