After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 633409 - prepare for the demise of size_request
prepare for the demise of size_request
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2010-10-28 23:11 UTC by Matthias Clasen
Modified: 2010-12-10 14:09 UTC
See Also:
GNOME target: 3.0
GNOME version: ---

Attachments
patch (3.72 KB, patch)
2010-10-28 23:11 UTC, Matthias Clasen 		committed Details | Review
patch (1.20 KB, patch)
2010-10-29 22:36 UTC, Matthias Clasen 		rejected Details | Review

Description Matthias Clasen 2010-10-28 23:11:42 UTC 
Created attachment 173444 [details] [review]
patch

The size_request vfunc is going away in GTK3.
This patch prepares totem for that.
Comment 1 Philip Withnall 2010-10-29 08:21:02 UTC 
Review of attachment 173444 [details] [review]:

Looks good, please commit to master.
Comment 2 Bastien Nocera 2010-10-29 16:21:43 UTC 
Comment on attachment 173444 [details] [review]
patch

There's another few calls/signals handling size-request, so leaving open.
Comment 3 Matthias Clasen 2010-10-29 22:36:55 UTC 
Created attachment 173531 [details] [review]
patch

hmm. does this patch do what is wanted ?
Comment 4 Bastien Nocera 2010-10-31 19:02:53 UTC 
Review of attachment 173531 [details] [review]:

This won't have the desired effect I'm afraid.
Comment 5 Bastien Nocera 2010-12-10 14:09:18 UTC 
Was fixed in:

commit ac16366ad0fa981311a707d56f0c85ab33b55acd
Author: Bastien Nocera <hadess@hadess.net>
Date:   Fri Dec 3 01:06:50 2010 +0000

    backend: Cleanup auto-resize code
    
    Thanks to Owen Taylor for the nice tricks!