After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 633401 - Fix warning from synthesized events with GdkDevice
Fix warning from synthesized events with GdkDevice
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2010-10-28 21:05 UTC by Owen Taylor
Modified: 2010-10-28 21:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix warning from synthesized events with GdkDevice (4.09 KB, patch)
2010-10-28 21:05 UTC, Owen Taylor 		committed Details | Review

Description Owen Taylor 2010-10-28 21:05:53 UTC 
In GTK+ 3, it's mandatory to have a GdkDevice in a synthesized event,
so fill in the pointer device for the events we synthesize and forward
to GTK+. Since gdk_device_set_event() only works for allocated events,
we need to switch to gdk_event_new() rather than using stack allocated
events.
Comment 1 Owen Taylor 2010-10-28 21:05:55 UTC 
Created attachment 173437 [details] [review]
Fix warning from synthesized events with GdkDevice
Comment 2 Dan Winship 2010-10-28 21:23:50 UTC 
Comment on attachment 173437 [details] [review]
Fix warning from synthesized events with GdkDevice

good except:

>to GTK+. Since gdk_device_set_event() only works for allocated events,

swapped "device" and "event" in the function name
Comment 3 Owen Taylor 2010-10-28 21:28:20 UTC 
Attachment 173437 [details] pushed as c40fab2 - Fix warning from synthesized events with GdkDevice