After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 633352 - prepare for the demise of size_request
prepare for the demise of size_request
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2010-10-28 14:04 UTC by Matthias Clasen
Modified: 2010-11-03 23:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (9.10 KB, patch)
2010-10-28 14:04 UTC, Matthias Clasen 		committed Details | Review

Description Matthias Clasen 2010-10-28 14:04:59 UTC 
Created attachment 173400 [details] [review]
patch

the size_request vfunc is going to be dropped in GTK3.
Here is a patch that prepares mutter for this. Only compile-tested.
Comment 1 Owen Taylor 2010-10-28 21:44:16 UTC 
Review of attachment 173400 [details] [review]:

MetaAccelLabel patch looks fine, works fine. MetaPreview patch goes boom:

+ Trace 224374

  • #0 ??
  • #1 compute_size_for_orientation
    at gtksizerequest.c line 294
  • #2 gtk_box_compute_size_for_orientation
    at gtkbox.c line 1170
  • #3 compute_size_for_orientation
    at gtksizerequest.c line 294
  • #4 gtk_bin_get_preferred_height_for_width
    at gtkbin.c line 265
  • #5 compute_size_for_orientation
    at gtksizerequest.c line 294 

Just run mutter-theme-viewer from the source tree to reproduce. Not really sure how the crashing code is supposed to work - if this is a widget bug, points to missing sanity checks in the sizing code.
Comment 2 Owen Taylor 2010-10-29 21:16:26 UTC 
Review of attachment 173400 [details] [review]:

Crash seems to have been from changes in GTK+ (to GtkButtonBox apparently) that have since been fixed up.

Patch looks good and works for me now - checked that the appearance of mutter-theme-viewer is consistent with GTK+ 2.0 based metacity-theme-viewer
Comment 3 Owen Taylor 2010-11-03 23:08:11 UTC 
Wrote commit message and pushed