After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 633322 - Merge the infobar branch into master
Merge the infobar branch into master
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: General
GIT
Other Linux
: Normal normal
: 0.9.0
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks:
 
 
Reported: 2010-10-28 05:44 UTC by Tim Howard
Modified: 2010-11-14 11:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
A patch merging from infobar to master (63.69 KB, patch)
2010-10-28 05:45 UTC, Tim Howard
reviewed Details | Review
Histogram update and act properly (1.57 KB, patch)
2010-10-30 07:42 UTC, Tim Howard
committed Details | Review

Description Tim Howard 2010-10-28 05:44:42 UTC
Merging the infobar branch into master.
Comment 1 Tim Howard 2010-10-28 05:45:19 UTC
Created attachment 173379 [details] [review]
A patch merging from infobar to master
Comment 2 Tim Howard 2010-10-28 05:49:06 UTC
Ah, it's wrong. The copyright header is the old one.
Comment 3 Ruben Vermeersch 2010-10-28 20:57:49 UTC
There seems to be something wrong with the histogram: it doesn't appear to update correctly. Also, the behavior of the histogram expander is a bit bizarre. Does anyone else see this?
Comment 4 Tim Howard 2010-10-28 22:42:32 UTC
I can confirm this. I am looking into it now.
Comment 5 Tim Howard 2010-10-30 07:42:31 UTC
Created attachment 173548 [details] [review]
Histogram update and act properly

This is a patch for the infobox branch.
Comment 6 Ruben Vermeersch 2010-11-14 11:37:51 UTC
Comment on attachment 173379 [details] [review]
A patch merging from infobar to master

Updated this one myself from the branch.
Comment 7 Ruben Vermeersch 2010-11-14 11:39:46 UTC
Review of attachment 173548 [details] [review]:

Your patch contains this:

From: tim <tim@tim-VirtualBox.(none)>

Please setup your git user data correctly.

From http://live.gnome.org/Git/Developers :

> Setting up Git
> 
> The first thing you should do is configure git to know who you are:
> 
> git config --global user.name "Rupert Monkey"
> git config --global user.email rupert@example.com

Updated it myself for this patch and merged, thanks!
Comment 8 Ruben Vermeersch 2010-11-14 11:40:26 UTC
In master now!