After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 633212 - [goom] Return not-negotiated when bps is unknown
[goom] Return not-negotiated when bps is unknown
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal blocker
: 0.10.26
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-10-26 18:46 UTC by Thiago Sousa Santos
Modified: 2010-10-28 13:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
goom: Return not-negotiated when bps is unknown (995 bytes, patch)
2010-10-26 18:46 UTC, Thiago Sousa Santos 		committed Details | Review

Description Thiago Sousa Santos 2010-10-26 18:46:43 UTC 
goom doesn't check if it has negotiated caps in the chain function.
This leads to a sigfpe
Comment 1 Thiago Sousa Santos 2010-10-26 18:46:47 UTC 
Created attachment 173282 [details] [review]
goom: Return not-negotiated when bps is unknown

If caps weren't negotiated, goom should return not-negotiated
from its chain functions instead of using bps unitialized, which
leads to a division by 0
Comment 2 Thiago Sousa Santos 2010-10-26 18:47:42 UTC 
This is simple enough, I think we can get it into the release.
Comment 3 Sebastian Dröge (slomo) 2010-10-28 13:20:14 UTC 
Comment on attachment 173282 [details] [review]
goom: Return not-negotiated when bps is unknown

Looks good and should be in the next pre-release
Comment 4 Thiago Sousa Santos 2010-10-28 13:45:56 UTC 
commit e400c8482aa7fce41acdda213e9d0d27bef15b45

Pushed.