(In reply to comment #0)
> As all the configuration should really be done in "Date and Time" panel in the
> control centre.

Yes! The clock-prefs dialogue was never intended as a proper configuration tool, but a reaction to a couple of bug reports requesting the date being displayed along the time. Are there any plans for adding such an option to the control center pane as well?

(The "show seconds" option is probably crack though.)

(In reply to comment #1)
> (In reply to comment #0)
> > As all the configuration should really be done in "Date and Time" panel in the
> > control centre.
> 
> Yes! The clock-prefs dialogue was never intended as a proper configuration
> tool, but a reaction to a couple of bug reports requesting the date being
> displayed along the time. Are there any plans for adding such an option to the
> control center pane as well?
> 
> (The "show seconds" option is probably crack though.)

It is bad idea.
1. new clock/calendar require configuration for multi Location
2. weather also will be added in near future(it will also require some options)

Lets rename gnome-shell-clock-preference to gnome-shell-preference
We need following options (at least):
1. theme changing
2. extension manager
3. changing animation time
4. enable/disable attaching modal dialog
5. manager(enable/disable/add) for open search providers
...

Lobbing settings based on where they're implemented rather than where they should have their rightful place is the sort of thing we're trying to avoid in the redesign of the control-center.

The first 2 items could, and should be added to the date & time panel.

(In reply to comment #2)
> It is bad idea.
> 1. new clock/calendar require configuration for multi Location
> 2. weather also will be added in near future(it will also require some options)
> 
> Lets rename gnome-shell-clock-preference to gnome-shell-preference
> We need following options (at least):

Ugh, no. The only thing those settings have in common is that they all are implemented inside the shell - it's an implementation detail users should not care about. Apart from that, I disagree that all those settings are needed:

> 1. theme changing

I'm not sure we want to encourage that - if we do, it should probably live in the (yet to be written?) gnome-tweaks module.

> 2. extension manager

Yes, that's something we need. Not sure where it would live, maybe a separate control center pane?


> 3. changing animation time

If we really won't that setting, I don't think it needs UI - obscure settings can live in GSettings, just like they do now with GConf.


> 4. enable/disable attaching modal dialog

Again, I don't think we need UI for that.


> 5. manager(enable/disable/add) for open search providers

I agree that we need this, but not lumped in with random other settings. Maybe we should add UI to the search field, similar how Firefox does it?

(In reply to comment #4)
> If we really won't that setting ...

Uhm - I meant "want" of course ... sorry, I'm a bit sick :(

Created attachment 175720 [details] [review]
clock: Use settings from gsettings-desktop-schemas

A setting for 12hr/24hr clock format has been added to
gsettings-desktop-schemas, so use that instead of a shell
specific schema.
As the setting can be controlled from the Date and Time panel of
gnome-control-center now, drop the temporary preference dialog
as well.

I'm not OK with not even having a hidden GSettings key for showing the date. We can debate what goes into System Settings, but just dropping the code and dropping the translated string from the translations and having to recreate it later doesn't make sense.

[ On the other hand, I don't care about "Show Seconds"... could have a hidden key, could not. There's no real use case for it. ]

The shell, until we figure out whether we want to show a preference setting for "show date in the clock", just needs to be updated to:
1) use the 12/24 hour setting from gsettings-desktop-schemas
2) still implement its own "show date" setting
3) remove the capplet

I don't think it was anybody's intention to just drop the "show date" code completely.

Created attachment 175724 [details] [review]
clock: Use settings from gsettings-desktop-schemas

(In reply to comment #7)
> I'm not OK with not even having a hidden GSettings key for showing the date. We
> can debate what goes into System Settings, but just dropping the code and
> dropping the translated string from the translations and having to recreate it
> later doesn't make sense.

OK. It would be nice to add at least the show-date key to the desktop-schemas - using two schemas for three keys is a bit weird.


> [ On the other hand, I don't care about "Show Seconds"... could have a hidden
> key, could not. There's no real use case for it. ]

I've left it in for now - we can still drop it later.

Created attachment 176672 [details] [review]
clock: Use settings from gsettings-desktop-schemas

Rebased to master.

Created attachment 176788 [details] [review]
clock: Use settings from gsettings-desktop-schemas

Rebased again.

Created attachment 176852 [details] [review]
clock: Use settings from gsettings-desktop-schemas

Forgot to update POTFILES for the removal of gnome-shell-clock-preferences

Review of attachment 176852 [details] [review]:

Looks fine to me

::: js/ui/panel.js
@@ +41,3 @@
     STANDARD_TRAY_ICON_SHELL_IMPLEMENTATION['bluetooth'] = imports.ui.status.bluetooth.Indicator;
 
+const CLOCK_FORMAT_KEY        = 'clock-format';

Might be good to add a comment like 
// in org.gnome.desktop.interface here

and 

// in ... 

for CLOCK_SHOW_DATE_KEY

Attachment 176852 [details] pushed as 24f1e87 - clock: Use settings from gsettings-desktop-schemas (with comments added)