After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 633011 - Add ability to handle (jpeg) Images to GstPlaybin
Add ability to handle (jpeg) Images to GstPlaybin
Status: RESOLVED FIXED
Product: rygel
Classification: Applications
Component: GstPlaybin plugin
git master
Other All
: Normal enhancement
: ---
Assigned To: Zeeshan Ali
Depends on:
Blocks:
 
 
Reported: 2010-10-24 05:47 UTC by j-frankish
Modified: 2011-10-16 14:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
playbin: Add support for image/jpeg and image/png (2.62 KB, patch)
2011-09-23 18:17 UTC, Jens Georg 		needs-work Details | Review
playbin: Add support for image/jpeg and image/png (2.33 KB, patch)
2011-09-26 06:53 UTC, Jens Georg 		committed Details | Review

Description j-frankish 2010-10-24 05:47:47 UTC 
Using rygel-0.8.1 and rygel-0.8.2 with gst-plugins-good-1.0.25, the rygel media renderer will not display jpeg images.
Comment 1 j-frankish 2011-05-21 07:31:38 UTC 
As of rygel-10.1, gupnp-av-cp will still not display jpeg images...
Comment 2 Zeeshan Ali 2011-05-21 13:07:48 UTC 
> As of rygel-10.1, gupnp-av-cp will still not display jpeg images...

Yup, this enhancement was never implemented. :(
Comment 3 Jens Georg 2011-09-08 22:30:20 UTC 
one problem is that souphttpsrc is hard-coded to request Streaming transfer mode:

+  soup_message_headers_append (src->msg->request_headers,
+      "transferMode.dlna.org", "Streaming");

This is not supported for images.
Comment 4 Jens Georg 2011-09-23 18:17:58 UTC 
Created attachment 197364 [details] [review]
playbin: Add support for image/jpeg and image/png
Comment 5 Zeeshan Ali 2011-09-24 13:48:48 UTC 
Review of attachment 197364 [details] [review]:

The changes to HTTPGet are obviously a work-around of a gst's souphttpsrc issue. Please correct that one there!
Comment 6 Zeeshan Ali 2011-09-24 13:51:48 UTC 
Review of attachment 197364 [details] [review]:

Otherwise, it works pretty nicely!
Comment 7 Jens Georg 2011-09-24 15:20:50 UTC 
(In reply to comment #5)
> Review of attachment 197364 [details] [review]:
> 
> The changes to HTTPGet are obviously a work-around of a gst's souphttpsrc
> issue. Please correct that one there!

Whoops, yes. Those I added for testing.
Comment 8 Jens Georg 2011-09-26 06:53:45 UTC 
Created attachment 197445 [details] [review]
playbin: Add support for image/jpeg and image/png

Use the typefind element of Playbin2 to determine if we're rendering an
image since UPnP allows the meta-data to be empty and it may not be
possible to guess the type from the URI.
Comment 9 Jens Georg 2011-09-26 06:54:48 UTC 
Removed the workaround code and also factored the type check into a method.
Comment 10 Zeeshan Ali 2011-10-16 14:06:34 UTC 
The following fixes have been pushed:
Comment 11 Zeeshan Ali 2011-10-16 14:07:47 UTC 
Never mind my last comment but its pushed now.