After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 632897 - flvmux does not set the correct nellymoser codec id
flvmux does not set the correct nellymoser codec id
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.10.x
Other Linux
: Normal normal
: 0.10.27
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-10-22 14:30 UTC by Tom Janiszewski
Modified: 2010-12-02 18:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
quick-fix patch for flvmux + nellymoser (374 bytes, patch)
2010-10-22 14:31 UTC, Tom Janiszewski 		none Details | Review
fix for nellymoser codecid setting (751 bytes, patch)
2010-10-23 23:37 UTC, Tom Janiszewski 		committed Details | Review

Description Tom Janiszewski 2010-10-22 14:30:22 UTC 
in gstflvmux.c, if the codec == audio/x-nellymoser and the rate is set to something like 22050 (standard nellymoser rate) the audio_codec id will not be set. 

A quick-fix patch for the bug is attached.
Comment 1 Tom Janiszewski 2010-10-22 14:31:35 UTC 
Created attachment 173009 [details] [review]
quick-fix patch for flvmux + nellymoser
Comment 2 Sebastian Dröge (slomo) 2010-10-23 19:23:26 UTC 
Please attach the patch in "git format-patch" format :) Looks good otherwise
Comment 3 Tom Janiszewski 2010-10-23 23:37:51 UTC 
Created attachment 173099 [details] [review]
fix for nellymoser codecid setting
Comment 4 Sebastian Dröge (slomo) 2010-10-24 08:17:14 UTC 
Thanks, I'll push this change after the 0.10.26 release soon.

You should update your GIT settings to use your name and email address btw
Comment 5 Tom Janiszewski 2010-10-24 15:37:39 UTC 
(In reply to comment #4)
> Thanks, I'll push this change after the 0.10.26 release soon.
> 
> You should update your GIT settings to use your name and email address btw

Will do, Thanks Sebastian ;)
Comment 6 Sebastian Dröge (slomo) 2010-12-02 18:26:33 UTC 
commit 05cc50528989426f9fae43f206bfc4d2e1f3725d
Author: Tom Janiszewski <Tom.Janiszewski@alcatel-lucent.com>
Date:   Sat Oct 23 19:34:00 2010 -0400

    flvmux: Fix for nellymoser codecid setting
    
    Fixes bug #632897.