After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 632889 - [multifdsink] [PATCH] Disconnect inactive clients in the select loop too
[multifdsink] [PATCH] Disconnect inactive clients in the select loop too
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 0.10.33
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-10-22 13:27 UTC by Andoni Morales
Modified: 2011-03-10 14:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-multifdsink-disconnect-inactive-clients-in-the-selec.patch (2.02 KB, patch)
2010-10-22 13:27 UTC, Andoni Morales 		none Details | Review
0001-multifdsink-disconnect-inactive-clients-in-the-selec.patch (2.26 KB, patch)
2010-10-22 13:54 UTC, Andoni Morales 		none Details | Review

Description Andoni Morales 2010-10-22 13:27:54 UTC 
Created attachment 172999 [details] [review]
0001-multifdsink-disconnect-inactive-clients-in-the-selec.patch

Clients are usually disconnected in the streaming thread if their inactivity     is bigger than the timeout. If no new buffers are to be rendered in the sink,    these clients will never be disconnected and for that reason it should be    handled in the select() loop too.
Comment 1 Andoni Morales 2010-10-22 13:54:33 UTC 
Created attachment 173003 [details] [review]
0001-multifdsink-disconnect-inactive-clients-in-the-selec.patch

Add missing check for timeout, instead of removing all the clients.
Comment 2 Wim Taymans 2010-10-25 07:50:33 UTC 
Sounds like a good idea. Will merge after freeze.
Comment 3 Andoni Morales 2011-02-12 19:41:02 UTC 
just a reminder :)
Comment 4 Wim Taymans 2011-03-10 14:11:34 UTC 
commit 8c13488022051543d1d653e83e0d35b632a63646
Author: Andoni Morales Alastruey <amorales@flumotion.com>
Date:   Fri Oct 22 14:01:26 2010 +0200

    multifdsink: disconnect inactive clients in the select loop too
    
    Clients are usually disconnected in the streaming thread if their inactivity
    is bigger than the timeout. If no new buffers are to be rendered in the sink,
    these clients will never be disconnected and for that reason it should be
    handled in the select() loop too.