After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 632494 - introspection: remove --allow-unprefixed
introspection: remove --allow-unprefixed
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Colin Walters
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2010-10-18 18:37 UTC by Owen Taylor
Modified: 2010-10-23 20:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
introspection: remove --allow-unprefixed (112.78 KB, patch)
2010-10-18 18:37 UTC, Owen Taylor 		committed Details | Review

Description Owen Taylor 2010-10-18 18:37:26 UTC 
Remove --allow-unprefixed option to the scanner, and fix resulting
problems:

 * theme.h and boxes.h are split into a main -header and a private
   header that includes stuff that is not generally useful and
   hard to introspect.

 * meta_display_get_atom() and meta_window_get_window_type_atom()
   are marked as (skip)

 * Fix annotation: (element-type Strut) => (element-type Meta.Strut)
Comment 1 Owen Taylor 2010-10-18 18:37:28 UTC 
Created attachment 172636 [details] [review]
introspection: remove --allow-unprefixed
Comment 2 Colin Walters 2010-10-19 19:34:10 UTC 
Review of attachment 172636 [details] [review]:

Why does theme.h continue to exist?  I don't see MetaTheme referenced elsewhere.

Otherwise looks fine.
Comment 3 Colin Walters 2010-10-19 19:34:23 UTC 
Review of attachment 172636 [details] [review]:

Also, thanks for doing this!
Comment 4 Owen Taylor 2010-10-19 19:47:21 UTC 
(In reply to comment #2)
> Review of attachment 172636 [details] [review]:
> 
> Why does theme.h continue to exist?  I don't see MetaTheme referenced
> elsewhere.
> 
> Otherwise looks fine

void meta_preview_set_theme         (MetaPreview            *preview,
                                     MetaTheme              *theme);

used by the theme preview code in gnome-control-center.
Comment 5 Colin Walters 2010-10-19 19:55:10 UTC 
Oh, I see, which you can get from theme-parser.h.  Let's move the meta_theme_load prototype into theme.h and kill off theme-parser.h then?
Comment 6 Owen Taylor 2010-10-23 19:57:28 UTC 
(In reply to comment #5)
> Oh, I see, which you can get from theme-parser.h.  Let's move the
> meta_theme_load prototype into theme.h and kill off theme-parser.h then?

Guess it depends on whether you think header files should be organized by .c file contents or by public objects. I'm happy to go with the public object story and kill theme-parser.h. Will push things that way.
Comment 7 Owen Taylor 2010-10-23 20:00:28 UTC 
Attachment 172636 [details] pushed as 52bc675 - introspection: remove --allow-unprefixed