After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 632485 - Replace JS_IsNativeFrame by the opposite new function JS_IsScriptFrame
Replace JS_IsNativeFrame by the opposite new function JS_IsScriptFrame
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other Linux
: Normal blocker
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2010-10-18 17:49 UTC by Quentin "Sardem FF7" Glidic
Modified: 2010-10-20 20:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
The very little patch (maybe the "version detection" should be safer) (793 bytes, patch)
2010-10-18 17:49 UTC, Quentin "Sardem FF7" Glidic 		none Details | Review
The (corrected) very little patch (maybe the "version detection" should be safer) (753 bytes, patch)
2010-10-19 07:52 UTC, Quentin "Sardem FF7" Glidic 		none Details | Review
The (recorrected) very little patch (maybe the "version detection" should be safer) (750 bytes, patch)
2010-10-19 07:55 UTC, Quentin "Sardem FF7" Glidic 		none Details | Review
Update patch with configure.ac check for new function (1.31 KB, patch)
2010-10-20 17:54 UTC, Quentin "Sardem FF7" Glidic 		committed Details | Review

Description Quentin "Sardem FF7" Glidic 2010-10-18 17:49:05 UTC 
Created attachment 172631 [details] [review]
The very little patch (maybe the "version detection" should be safer)

xulrunner upstream did a little change to JS debug API

They replace JS_IsNativeFrame by an opposite one, JS_IsScriptFrame

Compile with a recent xulrunner 2.0b8pre build (can't test, other issues)

Upstream commit : http://hg.mozilla.org/mozilla-central/rev/27a7da173598
Comment 1 Quentin "Sardem FF7" Glidic 2010-10-19 07:52:56 UTC 
Created attachment 172678 [details] [review]
The (corrected) very little patch (maybe the "version detection" should be safer)
Comment 2 Quentin "Sardem FF7" Glidic 2010-10-19 07:55:16 UTC 
Created attachment 172679 [details] [review]
The (recorrected) very little patch (maybe the "version detection" should be safer)
Comment 3 Colin Walters 2010-10-20 17:22:11 UTC 
Review of attachment 172679 [details] [review]:

Can you update this patch to look like how we fixed 632529?  It needs a check in configure.ac.
Comment 4 Quentin "Sardem FF7" Glidic 2010-10-20 17:54:07 UTC 
Created attachment 172858 [details] [review]
Update patch with configure.ac check for new function
Comment 5 Colin Walters 2010-10-20 20:38:37 UTC 
Review of attachment 172858 [details] [review]:

Looks good, thanks!