GNOME Bugzilla – Bug 632258
build issue with newer gcc
Last modified: 2010-10-16 19:48:21 UTC
Created attachment 172459 [details] [review] Gentoo patch for build issue + 2 additions by me Building gnet fails with at least gcc-4.5 and 4.4. http://bugs.gentoo.org/294558 The gnet-2.0.8-define-location.patch seems to solve the problem for compiling, still problems with tests, so I have added 2 additional changes (tcase_add_loop_test_raise_signal)
This doesn't look like the right fix. In fact it looks like it would make __gnet_tcase_add_test() call itself in a loop until the stack overflows and it crashes. Have you run this code? The build warning/error is probably due to upstream check having changed their API. If that is the case, then the check requirement and API usage needs to be updated. (Alternatively, one could pull in a static copy of check like we do for GStreamer, but since GNet is basically deprecated I can't really be bothered to do that).
This should fix it: http://git.gnome.org/browse/gnet/commit/?id=a61601a487394cbd5970c3b736aea71bf277ecc1 (Note that 'make check' will likely still fail as is, because it downloads from www.gnetlibrary.org, which has been discontinued, so that would need fixing as well if it's not #ifdef 0'ed yet)
Comment on attachment 172459 [details] [review] Gentoo patch for build issue + 2 additions by me Actually, I guess the -#define _tcase_add_test __gnet_tcase_add_test makes it work for you. But still, doesn't seem fully right.
(In reply to comment #2) > This should fix it: > > http://git.gnome.org/browse/gnet/commit/?id=a61601a487394cbd5970c3b736aea71bf277ecc1 > > (Note that 'make check' will likely still fail as is, because it downloads from > www.gnetlibrary.org, which has been discontinued, so that would need fixing as > well if it's not #ifdef 0'ed yet) sometime it is so easy, thx for the fix :)