After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 632197 - st-drawing-area: Avoid unnecessary repaints
st-drawing-area: Avoid unnecessary repaints
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2010-10-15 07:38 UTC by Florian Müllner
Modified: 2010-10-15 10:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
st-drawing-area: Avoid unnecessary repaints (1.14 KB, patch)
2010-10-15 07:38 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2010-10-15 07:38:27 UTC 
Make BoxPointer snappy again - see attached patch.
Comment 1 Florian Müllner 2010-10-15 07:38:29 UTC 
Created attachment 172409 [details] [review]
st-drawing-area: Avoid unnecessary repaints

StDrawingArea uses the member variable needs_repaint to keep track
of whether it needs repainting. The variable is set to TRUE correctly,
e.g. on allocation or style changes - alas, it is never set to FALSE,
resulting in the area being repainted continuously.
Comment 2 drago01 2010-10-15 10:26:51 UTC 
Review of attachment 172409 [details] [review]:

Makes sense.
Comment 3 drago01 2010-10-15 10:26:51 UTC 
Review of attachment 172409 [details] [review]:

Makes sense.
Comment 4 Florian Müllner 2010-10-15 10:34:41 UTC 
Attachment 172409 [details] pushed as 42c7366 - st-drawing-area: Avoid unnecessary repaints