After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 631799 - Remove even_if_mapped parameter to terminal_window_set_size()
Remove even_if_mapped parameter to terminal_window_set_size()
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on: 631797
Blocks:
 
 
Reported: 2010-10-10 03:08 UTC by Owen Taylor
Modified: 2010-10-11 19:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove even_if_mapped parameter to terminal_window_set_size() (6.29 KB, patch)
2010-10-10 03:08 UTC, Owen Taylor 		committed Details | Review

Description Owen Taylor 2010-10-10 03:08:40 UTC 
The even_if_mapped parameter to terminal_window_set_size() and
terminal_window_set_size_force_grid() doesn't have any useful
role any more. The original reason it was added is lost to
history, but it may had a residual role of making sure that
the the size set by terminal_window_set_size() didn't override
a default size set by gtk_window_parse_geometry(). With the
better handling of geometry from bug 592435, this is no longer
necessary.
Comment 1 Owen Taylor 2010-10-10 03:08:42 UTC 
Created attachment 172035 [details] [review]
Remove even_if_mapped parameter to terminal_window_set_size()
Comment 2 Owen Taylor 2010-10-10 03:12:16 UTC 
Tested with GTK+ 2 and GTK+ 3 by:

 - Starting default options
 - Starting with --geometry
 - DND detaching tabs
 - Switch between tabs with different font sizes

All seems to work properly. And certainly from a theoretical point of view I expect this to work right, though it's admittedly a fiddly area.
Comment 3 Owen Taylor 2010-10-11 19:54:48 UTC 
Comment on attachment 172035 [details] [review]
Remove even_if_mapped parameter to terminal_window_set_size()

Pushed