GNOME Bugzilla – Bug 631657
Empathy doesn't build with gcr-3
Last modified: 2011-08-29 10:12:37 UTC
empathy-tls-dialog.c: In function ‘build_gcr_widget’: empathy-tls-dialog.c:219: error: ‘GcrCertificateBasicsWidget’ undeclared (first use in this function) empathy-tls-dialog.c:219: error: (Each undeclared identifier is reported only once empathy-tls-dialog.c:219: error: for each function it appears in.) empathy-tls-dialog.c:219: error: ‘widget’ undeclared (first use in this function) cc1: warnings being treated as errors empathy-tls-dialog.c:220: error: ISO C90 forbids mixed declarations and code empathy-tls-dialog.c:232: error: implicit declaration of function ‘gcr_certificate_basics_widget_new’
Created attachment 171936 [details] [review] patch (I think) http://git.collabora.co.uk/?p=user/danni/empathy.git;a=shortlog;h=refs/heads/gcr-trivia-631657 I think this is the right patch. I haven't tested it though.
empathy-auth crashes when the dialog gets disposed, but it looks like a bug in gcr. Filed as bug #631840.
(In reply to comment #2) > empathy-auth crashes when the dialog gets disposed, but it looks like a bug in > gcr. Filed as bug #631840. This is fixed now. It works.
Created attachment 172082 [details] [review] this patch + other dialog trivia Ok, this is tested and works. Branch now includes two other pieces of trivial: (1) fix up formatting of secondary-text, remove formatting from translatable strings, include punctuation in translatable strings. (2) make the gcr widget at least 150 pixels high, so that you can actually read its contents
Review of attachment 172082 [details] [review]: ++
Merged to master.
This needs to be backported to the 2.32 branch, since the same API break happened in gcr-0. Otherwise, with an up-to-date gnome-keyring[-0], you can't build Empathy 2.32.x.
The changes happenned in the GNOME 3 version of gcr-0 (2.91.x) so we can just not support it in 2.32 as we did with libnotify. http://git.Collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/2.32-build
(In reply to comment #8) > The changes happenned in the GNOME 3 version of gcr-0 (2.91.x) so we can just > not support it in 2.32 as we did with libnotify. > http://git.Collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/2.32-build This branch is fine except for the following required change: ====================================================== @@ -180,9 +180,10 @@ PKG_CHECK_MODULES(LIBNOTIFY, libnotify >= $LIBNOTIFY_REQUIR # libnotify 0.7 introduced API changes PKG_CHECK_MODULES(LIBNOTIFY, libnotify < 0.7) PKG_CHECK_MODULES(UNIQUE, unique-1.0 >= $UNIQUE_REQUIRED) -PKG_CHECK_MODULES(GCR, gcr-0 >= $KEYRING_REQUIRED) # gnome-keyring breaks API in 2.91.x -PKG_CHECK_MODULES(GCR, gcr-0 < 2.91) +PKG_CHECK_MODULES(GCR, + gcr-0 < 2.91 + gcr-0 >= $KEYRING_REQUIRED) # Enable GSEAL checks if needed if test $USE_MAINTAINER_MODE = yes; then ====================================================== Autotools silently ignores at least one of the calls to PKG_CHECK_MODULES(GCR, ...), since it can't handle multiple calls with the same first argument. So we have to combine them into a single call.
Fixed and merged; will be in 2.32.1 This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.