GNOME Bugzilla – Bug 63160
Autofill won't go left or up
Last modified: 2004-12-22 21:47:04 UTC
Steps: 1. Put 10 in C7 2. Put 15 in C8 3. Highlight C7 and C8 4. Move mouse to bottom-right of C8 to get autofill mouse cursor 5. Move mouse to C6 Result: Autofill does not highlight C6 The same thing happens if you try to fill to the left. Ok, so maybe I use auto-fill in a little bit of a weird way, but I wonder if this is a serious problem with a right to left language such as Hebrew or Arabic where left-filling would be more common? P.S. Keep up the good work; I'm very impressed with 0.71 -- huge improvement over 0.67.
Filling up or left would potentially decrease a series. We may support it one day, but it is not high on our list of priorities.
If I provide a patch to do this, will you accept it?
Patches are always welcome. I'll warn you that it is not trivial. Please have a look at XL's behavior before attempting this. Thanks
Well, if it's not trivial, then it's fun :) As noted in Bug 63510, Edit, Fill, Autofill doesn't actually do anything; I'll take care of that here too (maybe as a separate patch).
Sorry, meant to assign to myself...
Created attachment 5944 [details] [review] Changes so far to support inverse highlighting
Created attachment 5962 [details] [review] Changes to support inverse autofill
OK, attachment 5962 [details] [review] is ready for QA. I used a gboolean to indicate whether inverse autofill was happening. As you can see in the patch, I'd like to replace it with an enumeration: FILL_DIR_{NORTH|EAST|SOUTH|WEST} Feel free to commit as is, or to re-assign to me and I'll do the enum thing (in sheet-autofill.h I suppose). Oops, I just noticed that I forgot to put src/ in front of most of the filenames in the Changelog. Sorry.
Code looked pretty reasonable as has been applied. The enum would be a nice touch. I tweaked the visiblity handling during an autoscroll but the majority remained.