After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 631596 - nautilus custom emblems should be placed in $XDG_DATA_HOME/icons/hicolor
nautilus custom emblems should be placed in $XDG_DATA_HOME/icons/hicolor
Status: RESOLVED OBSOLETE
Product: nautilus
Classification: Core
Component: general
2.32.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks: 523057
 
 
Reported: 2010-10-07 11:34 UTC by Jason
Modified: 2010-10-14 12:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
emblem xdg patch (2.21 KB, patch)
2010-10-07 11:34 UTC, Jason 		needs-work Details | Review

Description Jason 2010-10-07 11:34:10 UTC 
Created attachment 171887 [details] [review]
emblem xdg patch

See http://www.freedesktop.org/wiki/Specifications/basedir-spec

i found in libnautilus-private/nautilus-emblem-utils.c there still use ~/.icons/hicolor/, which is not match fd.o
Comment 1 Christian Persch 2010-10-07 13:22:20 UTC 
+	dir = g_build_filename (g_get_user_data_dir (),
+				"icons", "hicolor", "48x48", "emblems",
 				NULL);
[...] 
 	if (g_mkdir_with_parents (dir, 0755) != 0) {

Wrong perms; the spec says 0700.

Also, in the other changes, g_strdup_printf() isn't really the right way to build a path (even if the current code does it); use g_build_filename.
Comment 2 Cosimo Cecchi 2010-10-14 12:28:55 UTC 
nautilus-emblem-utils.c has gone from nautilus master some time ago, together with 'Background and Emblems', so this is OBSOLETE.