GNOME Bugzilla – Bug 631277
Regression: Crash when editing tags on unknown CD tracks
Last modified: 2010-12-14 14:02:05 UTC
Tag attributes cannot be edited on CD tracks (such as when importing a CD for which metadata was not fetched) - Banshee crashes. Steps to reproduce: (1) Insert a CD for which metadata will not be fetched. (2) Select a track from the 'Audio CD' list, and Edit Track Information... (3) Change some attribute, and press 'Save' (4) Watch the Banshee window disappear ;) cmd line output:
cmd line output: [Info 21:16:19.459] Querying MusicBrainz for Disc Release (qrIUicVH7WOxXlKoCp0lLDxdBVE-) [Info 21:16:19.696] Query finished (success: False, 0.236435 seconds) Marshaling response signal Exception in Gtk# callback delegate Note: Applications can use GLib.ExceptionManager.UnhandledException to handle the exception. System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.NullReferenceException: Object reference not set to an instance of an object at Banshee.Collection.Database.DatabaseTrackInfo.Update () [0x00000] in <filename unknown>:0 at Banshee.Gui.TrackEditor.TrackEditorDialog.SaveTrack (Banshee.Gui.TrackEditor.EditorTrackInfo track) [0x00000] in <filename unknown>:0 at Banshee.Gui.TrackEditor.TrackEditorDialog.Save () [0x00000] in <filename unknown>:0 at Banshee.Gui.TrackEditor.TrackEditorDialog+<Run>c__AnonStorey11.<>m__78 (System.Object o, Gtk.ResponseArgs args) [0x00000] in <filename unknown>:0 at (wrapper managed-to-native) System.Reflection.MonoMethod:InternalInvoke (object,object[],System.Exception&) at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00000] in <filename unknown>:0 --- End of inner exception stack trace --- at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00000] in <filename unknown>:0 at System.Reflection.MethodBase.Invoke (System.Object obj, System.Object[] parameters) [0x00000] in <filename unknown>:0 at System.Delegate.DynamicInvokeImpl (System.Object[] args) [0x00000] in <filename unknown>:0 at System.MulticastDelegate.DynamicInvokeImpl (System.Object[] args) [0x00000] in <filename unknown>:0 at System.Delegate.DynamicInvoke (System.Object[] args) [0x00000] in <filename unknown>:0 at GLib.Signal.ClosureInvokedCB (System.Object o, GLib.ClosureInvokedArgs args) [0x00000] in <filename unknown>:0 at GLib.SignalClosure.Invoke (GLib.ClosureInvokedArgs args) [0x00000] in <filename unknown>:0 at GLib.SignalClosure.MarshalCallback (IntPtr raw_closure, IntPtr return_val, UInt32 n_param_vals, IntPtr param_values, IntPtr invocation_hint, IntPtr marshal_data) [0x00000] in <filename unknown>:0 at GLib.ExceptionManager.RaiseUnhandledException(System.Exception e, Boolean is_terminal) at GLib.SignalClosure.MarshalCallback(IntPtr raw_closure, IntPtr return_val, UInt32 n_param_vals, IntPtr param_values, IntPtr invocation_hint, IntPtr marshal_data) at Gtk.Application.gtk_main() at Gtk.Application.Run() at Banshee.Gui.GtkBaseClient.Run() at Banshee.Gui.GtkBaseClient.Startup() at Hyena.Gui.CleanRoomStartup.Startup(Hyena.Gui.StartupInvocationHandler startup) at Banshee.Gui.GtkBaseClient.Startup() at Banshee.Gui.GtkBaseClient.Startup(System.String[] args) at Nereid.Client.Main(System.String[] args) at System.AppDomain.ExecuteAssembly(System.Reflection.Assembly , System.String[] ) at System.AppDomain.ExecuteAssemblyInternal(System.Reflection.Assembly a, System.String[] args) at System.AppDomain.ExecuteAssembly(System.String assemblyFile, System.Security.Policy.Evidence assemblySecurity, System.String[] args) at System.AppDomain.ExecuteAssembly(System.String assemblyFile) at Booter.Booter.BootClient(System.String clientName) at Booter.Booter.Main()
I'm having the same issue and get the same backtrace. This also occurs when editing CD metadata that has been fetched. I'm on 64 bit Ubuntu 10.04 using Banshee 1.8.0 from the Ubuntu PPA. Mono JIT compiler version 2.4.4 (Debian 2.4.4~svn151842-1ubuntu4).
Ooops, my fault.
Created attachment 171731 [details] [review] Patch v1 Proposed fix.
Comment on attachment 171731 [details] [review] Patch v1 Thanks, I'll commit to the stable branch too.
Was trying to push to the stable branch but found out that Gabriel already did :) This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.
*** Bug 631973 has been marked as a duplicate of this bug. ***
*** Bug 633564 has been marked as a duplicate of this bug. ***
*** Bug 634145 has been marked as a duplicate of this bug. ***
*** Bug 637172 has been marked as a duplicate of this bug. ***