GNOME Bugzilla – Bug 631050
Thumbnails get lost when the width of the side pane is changed
Last modified: 2014-03-17 16:28:55 UTC
The range of thumbnails shown in the side pane is lost when you change the width of the side pane. For example, I've got pages 92 - 95, and when the side pane turns into two columns of thumbnails, I've got pages 199 - 206. This presumably misbehaviour is more evident when it is shown the thumbnail of the page you're viewing and it get lost when you change the width of the side pane. (Reported by Stephen Dittoe in the evince mailing list, 29 Sep 2010)
I think the problem is the thumbnail view (the scrollview) stays in the same position, but the content changed. The new pages shown is approximately the double. It happens when doing the opposite, too. If the thumbnail view shows 2 columns and the selected is page 94, then when resizing the view to a smaller width the pages shown change to 47-50 (around half the previous one). If the user moves one page forward or backward, the thumbnail view gets updated. So, I think there is a missing call to sync method or something like that when the thumbnail view changes.
Created attachment 244376 [details] [review] Patch that re-sets current page when updating the visible range Hi! This patch fix the issue for me, but I'm not sure it is the correct fix. What do you think? /Jonas
Review of attachment 244376 [details] [review]: This patch looks good to me, it applies correctly to master and fixes the issue. Carlos, Christian: ok to commit?
Probably we would like to apply this one to both, master and 3.10.
What happened to this? :)
Review of attachment 244376 [details] [review]: This patch is wrong, this is called when scrolling up/down in the sidebar, so you can't never scroll to a position where the current page is not visible.
Created attachment 272138 [details] [review] Keep current page in visible area when the sidebar is resized What about something like this? I think gtk icon view should try to keep the visible area when the number of columns shown changes, though.
Comment on attachment 272138 [details] [review] Keep current page in visible area when the sidebar is resized Pushed to git master