After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 631000 - string contains name of windows, which is not exists
string contains name of windows, which is not exists
Status: RESOLVED FIXED
Product: tomboy
Classification: Applications
Component: General
unspecified
Other Linux
: Low trivial
: ---
Assigned To: Tomboy Maintainers
Tomboy Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-09-30 13:21 UTC by Pavol Klačanský
Modified: 2011-04-18 04:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Search window renamed to "Search All Notes" window (1.93 KB, patch)
2010-10-06 19:59 UTC, Pavol Klačanský
needs-work Details | Review

Description Pavol Klačanský 2010-09-30 13:21:27 UTC
#: ../data/tomboy.schemas.in.h:5
msgid "Determines X coordinate of Search window; stored on Tomboy exit."

Why is "Search window" with upper case "S"? There is no string named "Search window"

It is used many times in file
Comment 1 Sandy Armstrong 2010-09-30 14:08:00 UTC
I like to capitalize words that refer to window titles.  I am not sure what the recommended approach is.
Comment 2 Pavol Klačanský 2010-10-06 18:57:23 UTC
could you post me screenshot with window, which is named "Search"?
Comment 3 Sandy Armstrong 2010-10-06 19:01:38 UTC
It's actually called Search All Notes.  It's the window you get when you right-click the Tomboy icon and select "Search All Notes".
Comment 4 Pavol Klačanský 2010-10-06 19:10:11 UTC
Yes, I know, but that is point, there is no Search window, but Search all notes, I think, users can be confused
Comment 5 Sandy Armstrong 2010-10-06 19:20:16 UTC
I think it's pretty clear, but changing it to Search All Notes would be even clearer.  Confirming the bug.

This is pretty minor, though, because the string is only seen by users messing around in GConf Editor.

Patches welcome.
Comment 6 Pavol Klačanský 2010-10-06 19:51:14 UTC
Yeah, please, add quotes to text like \"Search All Notes\"
Comment 7 Pavol Klačanský 2010-10-06 19:59:17 UTC
Created attachment 171846 [details] [review]
Search window renamed to "Search All Notes" window

This patch should fix it
Comment 8 Sandy Armstrong 2010-10-06 20:50:16 UTC
Review of attachment 171846 [details] [review]:

I don't think the quotes are okay, they probably need to be escaped or something since this is an XML file.  Either remove them, or replace with " .  If you can then build and install and verify that gconf-editor shows the string correctly, then feel free to push.

If you can't build and install to test it, then I'll push after I've had a chance to verify.

Thanks for the patch!
Comment 9 Pavol Klačanský 2010-10-07 11:24:34 UTC
There are other strings with "" in this document, on weekend, I can test it
Comment 10 Pavol Klačanský 2010-10-09 08:18:56 UTC
I have tested it by adding new schema (gconf-schemas)

It works properly at me, I think, <> need be escaped, not "", because it is in <tag>text</tag>
Comment 11 Pavol Klačanský 2010-10-14 17:14:57 UTC
so?
Comment 12 Jared Jennings 2011-04-18 04:30:03 UTC
Committed c1eb1bd8d1dc9a5107f7acb9959ac13862d48893