Created attachment 171205 [details] [review]
gtk_adjustment_new() should return a GtkAdjustment* instead a Gobject*

Created attachment 171206 [details] [review]
Remove unneded casts

Review of attachment 171205 [details] [review]:

::: gtk/gtkadjustment.c
@@ +322,3 @@
 gtk_adjustment_new (gdouble value,
 		    gdouble lower,
 		    gdouble upper,

You need to add a cast in the return statement here. g_object_new just gives you a GObject *

Review of attachment 171206 [details] [review]:

Looks good

Thanks for the review

(In reply to comment #3)
> Review of attachment 171205 [details] [review]:
> 
> ::: gtk/gtkadjustment.c
> @@ +322,3 @@
>  gtk_adjustment_new (gdouble value,
>              gdouble lower,
>              gdouble upper,
> 
> You need to add a cast in the return statement here. g_object_new just gives
> you a GObject *

Are you sure about this? Other object like gtkrecentfilter, gtktreeviewcolumn or gtkfilefilter don't need that casts.

(In reply to comment #3)
> Review of attachment 171205 [details] [review]:
> 
> ::: gtk/gtkadjustment.c
> @@ +322,3 @@
>  gtk_adjustment_new (gdouble value,
>              gdouble lower,
>              gdouble upper,
> 
> You need to add a cast in the return statement here. g_object_new just gives
> you a GObject *

no: g_object_new() returns a gpointer exactly for this case.

My bad. I blame my age...

So, go ahead then.

Comment on attachment 171205 [details] [review]
gtk_adjustment_new() should return a GtkAdjustment* instead a Gobject*

commit 42f480a537da89eac587a5a67fbf64ab248cd931

Comment on attachment 171206 [details] [review]
Remove unneded casts

commit b072ea220cb938471c3ce5cb2fbd1e750112938b