After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 630690 - drop GtkObject use
drop GtkObject use
Status: RESOLVED FIXED
Product: glade
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Glade 3 Maintainers
Glade 3 Maintainers
Depends on:
Blocks: 630874 636726
 
 
Reported: 2010-09-27 03:49 UTC by Matthias Clasen
Modified: 2010-12-30 16:02 UTC
See Also:
GNOME target: 3.0
GNOME version: ---


Attachments
patch (2.56 KB, patch)
2010-09-27 03:49 UTC, Matthias Clasen
committed Details | Review

Description Matthias Clasen 2010-09-27 03:49:12 UTC
Created attachment 171172 [details] [review]
patch

GtkObject is gone in GTK3. See
http://live.gnome.org/GnomeGoals/GtkObjectRemoval
Comment 1 Tristan Van Berkom 2010-09-27 10:25:07 UTC
I'm a little bit worried... maybe this patch to Glade is going to
work fine... the part in glade_widget_dispose() that leaves old GtkObjects
such as adjustments and size-groups is a little sensitive (i.e. breaking
reference cycles is an important step when trying to balance out refcounts
at project close time... a painful exercise that often needs repeating).

However on a more global picture, how are we supposed to handle breaking
of circular object references with the new scheme ?

I think it might be wise to push GtkWidget::destroy signal back to the 
GObject level instead of absorbing it into GtkWidget
(people can always chose to call g_object_run_dispose(), but that still
doesn't provide any notifications to the objects which should unref the
dying object at dispose time).
Comment 2 Havoc Pennington 2010-10-11 21:57:12 UTC
does g_object_weak_ref() solve the problem?
Comment 3 Johannes Schmid 2010-11-15 23:17:29 UTC
I committed this in offscreen-gtk3 branch and it doesn't seem to cause any problems, yet.
Comment 4 Javier Jardón (IRC: jjardon) 2010-12-30 16:02:23 UTC
Comment on attachment 171172 [details] [review]
patch

commit cbc454d050a79e8ff863b236e635997672cbd944
Comment 5 Javier Jardón (IRC: jjardon) 2010-12-30 16:02:38 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.