After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 630669 - [bce] Make Variable BANSHEE_LIBS does not contain Lastfm.dll
[bce] Make Variable BANSHEE_LIBS does not contain Lastfm.dll
Status: RESOLVED NOTABUG
Product: banshee
Classification: Other
Component: general
git master
Other Linux
: Normal minor
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks: 630673
 
 
Reported: 2010-09-26 23:33 UTC by Raimo Radczewski
Modified: 2010-10-02 10:12 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Raimo Radczewski 2010-09-26 23:33:27 UTC
As said in the summary, the BANSHEE_LIBS Variable, used for declaration of dependencies to link against in a Makefile.am, does not contain Lastfm.dll, although it is build along with other official Banshee Libraries.

Community Extensions that use Lastfm.* have to hardcode -r:/path/to/Lastfm.dll in order to build.

This is a sample BANSHEE_LIBS, generated from bce git-master (6c456d1757d2590d4bff43db3039db6fed4b4987) with Banshee build from git-master on 2010-09-23 22:46:42 CEST on Ubuntu 10.04 32bit

BANSHEE_LIBS = -r:/usr/local/lib/banshee-1/Banshee.Widgets.dll -r:/usr/local/lib/banshee-1/Banshee.ThickClient.dll -r:/usr/local/lib/banshee-1/Banshee.Services.dll -r:Mono.Cairo -r:/usr/local/lib/banshee-1/Hyena.Gui.dll -r:/usr/local/lib/banshee-1/Banshee.Core.dll -r:System -r:/usr/local/lib/banshee-1/Mono.Media.dll -r:Mono.Posix -r:/usr/local/lib/banshee-1/Hyena.dll -r:System.Data -r:/usr/local/lib/banshee-1/Mono.Data.Sqlite -r:/usr/local/lib/banshee-1/Hyena.Data.Sqlite.dll -r:/usr/local/lib/banshee-1/MusicBrainz.dll -r:/usr/lib/cli/NDesk.DBus-1.0/NDesk.DBus.dll -r:/usr/lib/cli/NDesk.DBus.GLib-1.0/NDesk.DBus.GLib.dll -r:/usr/lib/pkgconfig/../../lib/cli/glib-sharp-2.0/glib-sharp.dll -r:/usr/lib/cli/Mono.Addins-0.2/Mono.Addins.dll -r:/usr/lib/pkgconfig/../../lib/cli/pango-sharp-2.0/pango-sharp.dll -r:/usr/lib/pkgconfig/../../lib/cli/atk-sharp-2.0/atk-sharp.dll -r:/usr/lib/pkgconfig/../../lib/cli/gdk-sharp-2.0/gdk-sharp.dll -r:/usr/lib/pkgconfig/../../lib/cli/gtk-sharp-2.0/gtk-sharp.dll -r:/usr/lib/cli/taglib-sharp-2.0/taglib-sharp.dll
Comment 1 Bertrand Lorentz 2010-10-02 10:12:36 UTC
BANSHEE_LIBS is defined the configure.ac file for b-c-e, and it's taking its value from the banshee-1-thickclient.pc pkg-config file.
It references the commonly used libraries for extensions.

If you want to reference Last.fm libraries, you have to add a new variable and get its value from the banshee-1-lastfm.pc pkg-config file.

You can see how the ClutterFlow does it with banshee-1-nowplaying and BANSHEE_NOWPLAYING_LIBS, or the Lyrics extension with banshee-1-webbrowser and BANSHEE_WEBBROWSER_LIBS.

If you have trouble with that, I'll set it up when I merge your extension into b-c-e.