After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 630627 - (PHPExcel) Compatibility issues when opening Excel 2007 file created with PHPExcel
(PHPExcel)
Compatibility issues when opening Excel 2007 file created with PHPExcel
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: import/export MS Excel (tm)
1.10.x
Other Linux
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2010-09-26 14:08 UTC by Bavo Janss
Modified: 2010-10-01 12:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
sample PHPExcel generated file, with comments and formatting (9.44 KB, application/vnd.openxmlformats-officedocument.spreadsheetml.sheet)
2010-09-26 14:08 UTC, Bavo Janss 		  Details
Initial patch (6.66 KB, patch)
2010-09-28 14:08 UTC, Jean Bréfort 		accepted-commit_now Details | Review

Description Bavo Janss 2010-09-26 14:08:14 UTC 
Created attachment 171127 [details]
sample PHPExcel generated file, with comments and formatting

When creating a Excel 2007 file with PHPExcel I have found 2 issues.
1.
The first is the fact that cell-comments do show when opened in MS Excel but are missing when opening the file GNumeric. Once the file is saved in MS Excel and then opened in GNumeric the comments appear. 
This is probably due to the fact the comments in the PHPExcel file do not fully comply to MS's standards. But Excel seems to be more flexible in overcoming these than GNumeric is.
2.
The second is the fact that formatting appears to be OK when the file is opened in GNumeric (background colors, alignment, bold, etc.). However after saving the file (2007 format) all formatting is lost. When saving the file in Excel 2000/2003 format formatting is preserved.

regards,

Bavo
Comment 1 Andreas J. Guelzow 2010-09-26 14:43:01 UTC 
Issue 2 is bug 532635
Comment 2 Jean Bréfort 2010-09-27 07:54:58 UTC 
Are you sure we import comments from an xlsx file written by Excel itself? I do not find any related code in xlsx-read.c.
Comment 3 Jean Bréfort 2010-09-28 14:08:58 UTC 
Created attachment 171262 [details] [review]
Initial patch

This patch does not import comment author (the sample file has an empty author node), and does not import rich text.
Worse, long comments are displayed on one line and they are larger than my screen, but this is probably another issue. Should we limit comments to some maximum width?

Comments are not exported to xlsx for now.
Comment 4 Andreas J. Guelzow 2010-09-29 23:53:56 UTC 
Jean the long comments issue is really unrelated to xlsx import. We get long comments even within Gnumeric.
Comment 5 Jean Bréfort 2010-09-30 08:13:13 UTC 
Yes, seen that.
Comment 6 Andreas J. Guelzow 2010-09-30 19:42:22 UTC 
Comment on attachment 171262 [details] [review]
Initial patch

looks good to me
Comment 7 Jean Bréfort 2010-09-30 20:18:56 UTC 
I'll wait a bit until I have th code to export the comments. This should be done during the week-end. I also need to import the markup.
Comment 8 Jean Bréfort 2010-10-01 12:25:33 UTC 
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.

At least comments are imported and exported now. #532635 is still there.