GNOME Bugzilla – Bug 630521
Remove some remaining API warts from tab dnd api
Last modified: 2011-02-04 16:12:22 UTC
The window creation hook is problematic, since it is global. And we already have a create-window signal anyway. The group is currently specified as a bare pointer without a destroy notify, which is very problematic for language bindings. Instead, we can just use an interned string.
Created attachment 171035 [details] [review] remove the window creation hook
Created attachment 171036 [details] [review] group -> group_name
Setting 2.24 as target milestore as we should deprecate the former API in 2.x
(In reply to comment #2) > Created an attachment (id=171036) [details] [review] > group -> group_name My immediate thought here is , this is almost like the older group-id except you pass a string which internally is a quark. With the older API you would pass a quark (or any integer) directly. It is probably slightly more natural to use a string. I do agree that it is better than the obscure group pointer and it is a good idea to use quarks.
(In reply to comment #1) > Created an attachment (id=171035) [details] [review] > remove the window creation hook I second removing the hook. It is simply redundant and not a nice interface.
(In reply to comment #4) > (In reply to comment #2) > > Created an attachment (id=171036) [details] [review] [details] [review] > > group -> group_name > > My immediate thought here is , this is almost like the older group-id except > you pass a string which internally is a quark. With the older API you would > pass a quark (or any integer) directly. It is probably slightly more natural to > use a string. > > I do agree that it is better than the obscure group pointer and it is a good > idea to use quarks. The big advantage of strings over integers is that it is easy to avoid collisions by using a prefix. And using quarks in the api is a bit icky.