After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 630520 - Don't try to unref event->dnd.context unconditionally as it's not set in gdk_event_new but eventually later.
Don't try to unref event->dnd.context unconditionally as it's not set in gdk_...
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: X11
2.90.x
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2010-09-24 14:32 UTC by Tomeu Vizoso
Modified: 2010-09-24 16:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't try to unref event->dnd.context unconditionally as it's not set in gdk_event_new but eventually later. (859 bytes, patch)
2010-09-24 14:32 UTC, Tomeu Vizoso 		committed Details | Review

Description Tomeu Vizoso 2010-09-24 14:32:12 UTC 
Otherwise the API docs are incorrect.
Comment 1 Tomeu Vizoso 2010-09-24 14:32:14 UTC 
Created attachment 171033 [details] [review]
Don't try to unref event->dnd.context unconditionally as it's not set in gdk_event_new but eventually later.
Comment 2 Colin Walters 2010-09-24 16:19:22 UTC 
Review of attachment 171033 [details] [review]:

Looks fine to me except for the commit message rewording requested via IRC.