After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 630404 - Inclusion of the Scilab lang file
Inclusion of the Scilab lang file
Status: RESOLVED FIXED
Product: gtksourceview
Classification: Platform
Component: Syntax files
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GTK Sourceview maintainers
GTK Sourceview maintainers
Depends on:
Blocks:
 
 
Reported: 2010-09-23 12:24 UTC by Sylvestre Ledru
Modified: 2010-11-29 17:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Scilab lang (17.82 KB, text/plain)
2010-09-23 12:24 UTC, Sylvestre Ledru 		  Details
Updated Scilab management (8.05 KB, patch)
2010-09-23 15:31 UTC, Sylvestre Ledru 		needs-work Details | Review
Updated Scilab management v3 (7.79 KB, patch)
2010-09-27 08:42 UTC, Sylvestre Ledru 		reviewed Details | Review
Scilab test case (330 bytes, application/octet-stream)
2010-09-27 08:43 UTC, Sylvestre Ledru 		  Details
Scilab test case v2 (1.19 KB, text/plain)
2010-11-29 11:10 UTC, Sylvestre Ledru 		  Details

Description Sylvestre Ledru 2010-09-23 12:24:59 UTC 
Created attachment 170897 [details]
Scilab lang

Could you consider the inclusion of the Scilab lang file. 
This is the work of Florent Cadoux.

Let me know if you need any fix/improvements.

Thanks.
Comment 1 Ignacio Casal Quinteiro (nacho) 2010-09-23 12:30:38 UTC 
This lang file seems to use the old format, you would have to port it to the new format if you want it included upstream. Also we would like to know if the author is ok by having it included. And finally the copyright header is missing in the file.
Comment 2 Sylvestre Ledru 2010-09-23 12:49:22 UTC 
OK, sorry about the wrong format.
Comment 3 Sylvestre Ledru 2010-09-23 15:31:03 UTC 
Created attachment 170926 [details] [review]
Updated Scilab management

Here is the updated file.
I took the Octave language definition and adapted for Scilab.
Comment 4 Ignacio Casal Quinteiro (nacho) 2010-09-24 11:17:57 UTC 
Review of attachment 170926 [details] [review]:

Apart from the comments the file looks good. Could you also provide an example of no more than 10 lines to add to our test cases?

::: data/language-specs/scilab.lang
@@ +3,3 @@
+
+ This file is part of GtkSourceView.
+ This file is a modification of the octave.lang adapted for the Scilab language

all languages are copy pasted from other so no need to add this header.
and the lang file isn't similar to the octave one.

@@ +27,3 @@
+<language id="scilab" _name="Scilab" version="2.0" _section="Scientific">
+  <metadata>
+    <property name="mimetypes">text/x-scilab</property>

does this mime type exists or you added without knowing that you can remove it?
Comment 5 Sylvestre Ledru 2010-09-27 08:42:19 UTC 
Created attachment 171179 [details] [review]
Updated Scilab management v3

Here is the updated file.
Comment 6 Sylvestre Ledru 2010-09-27 08:43:10 UTC 
Created attachment 171180 [details]
Scilab test case

By the way, I don't know why some keywords starting with % are not taken in account ?
%t, %pi, etc
Comment 7 Sylvestre Ledru 2010-11-26 17:48:45 UTC 
Ping?
Comment 8 Ignacio Casal Quinteiro (nacho) 2010-11-26 19:28:30 UTC 
ups sorry, I totally forgot about it. I'll check today or tomorrow.
Comment 9 Ignacio Casal Quinteiro (nacho) 2010-11-27 17:56:00 UTC 
Review of attachment 171179 [details] [review]:

looks good.
Comment 10 Ignacio Casal Quinteiro (nacho) 2010-11-27 17:59:02 UTC 
can you provide a test case lgpl? this means one made by you that we can add to our test cases.
Comment 11 Sylvestre Ledru 2010-11-29 11:10:44 UTC 
Created attachment 175454 [details]
Scilab test case v2

Here it is as LGPL
Comment 12 Ignacio Casal Quinteiro (nacho) 2010-11-29 17:54:19 UTC 
Pushed a patch with the lang, and the test. Thanks a lot for it.